refactor(tests): rate limit wait helper

POST to /eligibility/confirm needs to respect rate limit
cal-itp · Apr 14, 2023 · 6642af0 · 6642af0
1 parent ea98a9b
commit 6642af0
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 5 deletions.
diff --git a/tests/cypress/specs/courtesy-cards.cy.js b/tests/cypress/specs/courtesy-cards.cy.js
@@ -10,6 +10,8 @@ describe("Courtesy Cards", () => {
   });
 
   it("Confirms an eligible user", () => {
+    helpers.rateLimitWait();
+
     cy.get("#sub").type(users.eligible.sub);
     cy.get("#name").type(users.eligible.name);
     cy.get("#form-eligibility-verification button[type='submit']").click();
@@ -18,6 +20,8 @@ describe("Courtesy Cards", () => {
   });
 
   it("Rejects an ineligible user", () => {
+    helpers.rateLimitWait();
+
     cy.get("#sub").type(users.ineligible.sub);
     cy.get("#name").type(users.ineligible.name);
     cy.get("#form-eligibility-verification button[type='submit']").click();

diff --git a/tests/cypress/specs/helpers.js b/tests/cypress/specs/helpers.js
@@ -2,6 +2,15 @@ const agencies = require("../fixtures/transit-agencies");
 
 const agency = agencies[0].fields;
 
+// from nginx.conf
+const RATE_LIMIT = 12;
+// 12 requests/minute ==> 5 seconds in milliseconds
+const WAIT_TIME = (60 / RATE_LIMIT) * 1000;
+
+export const rateLimitWait = () => {
+  cy.wait(WAIT_TIME);
+};
+
 export const selectAgency = () => {
   cy.location("pathname").should("eq", "/");
 

diff --git a/tests/cypress/specs/rate-limit.cy.js b/tests/cypress/specs/rate-limit.cy.js
@@ -2,9 +2,6 @@ const users = require("../fixtures/users.json");
 const helpers = require("./helpers");
 const { eligibility_url, post_confirm } = require("../plugins/eligibility");
 
-const RATE_LIMIT = 12;
-// 5 seconds in milliseconds => allows 12 requests/minute
-const WAIT_TIME = 5 * 1000;
 const SUCCESS_STATUS = 302;
 const FAIL_STATUS = 503;
 
@@ -43,7 +40,7 @@ describe("Rate limiting feature spec", () => {
 
   it("Allows requests with enough time in between", () => {
     // start with a wait, since the previous test already triggered the limit
-    cy.wait(WAIT_TIME);
+    helpers.rateLimitWait();
 
     const sub = users.ineligible.sub;
     const name = users.ineligible.name;
@@ -59,7 +56,7 @@ describe("Rate limiting feature spec", () => {
         for (let i = 0; i < RATE_LIMIT; i++) {
           post_confirm(csrfmiddlewaretoken, sub, name, false).then((res) => {
             expect(res.status).to.eq(SUCCESS_STATUS);
-            cy.wait(WAIT_TIME);
+            helpers.rateLimitWait();
           });
         }
       });