fix(Cypress): update feature tests for new flow

docs/tests/README.md

@@ -51,6 +51,8 @@ CYPRESS_baseUrl=http://localhost:8000 npm run cypress:open
 
 See `tests/cypress/package.json` for more cypress scripts.
 
+As of Cypress 12.5.1 with Firefox 109, there is a CSRF issue that prevents the tests from passing; unclear if this is a bug in Cypress or what. Use one of the other browser options.
+
 ## Pytest
 
 The tests done at a request/unit level are run via [pytest-django](https://pytest-django.readthedocs.io/en/latest/index.html).

tests/cypress/fixtures/users.json

@@ -1,14 +1,10 @@
 {
   "eligible": {
-    "name": "Garcia",
-    "sub": "A1234567"
+    "name": "Gonzales",
+    "sub": "32587"
   },
   "ineligible": {
     "name": "Bob",
-    "sub": "A1234567"
-  },
-  "invalidSub": {
-    "name": "Garcia",
-    "sub": "A12347"
+    "sub": "12345"
   }
 }

tests/cypress/specs/feature/eligibility.cy.js

@@ -1,49 +1,40 @@
 const agencies = require("../../fixtures/transit-agencies");
 const users = require("../../fixtures/users.json");
 
-const eligibility_url = "/eligibility/confirm";
-
 describe("Eligibility confirmation flow", () => {
   beforeEach(() => {
     cy.visit("/");
-    cy.contains(agencies[0].fields.short_name).click();
-    cy.contains("Get started").click();
+
+    // agency selection
+    cy.contains("Choose Your Provider").click();
+    cy.contains(agencies[0].fields.long_name).click();
+
+    // select Courtesy Card
+    // TODO find a more robust way to do this
+    cy.get('#form-verifier-selection [type="radio"]').check("2");
+    cy.get("#form-verifier-selection button[type='submit']").click();
     cy.contains("Continue").click();
   });
 
   it("Confirms an eligible user", () => {
     cy.get("#sub").type(users.eligible.sub);
     cy.get("#name").type(users.eligible.name);
-    cy.get("input[type='submit']").click();
+    cy.get("#form-eligibility-verification button[type='submit']").click();
 
-    cy.contains("Great! You’re eligible for a discount!");
+    cy.contains("Your eligibility is confirmed!");
   });
 
   it("Rejects an ineligible user", () => {
     cy.get("#sub").type(users.ineligible.sub);
     cy.get("#name").type(users.ineligible.name);
-    cy.get("input[type='submit']").click();
+    cy.get("#form-eligibility-verification button[type='submit']").click();
 
-    cy.contains("We can’t confirm your age");
-    cy.contains(
-      "You may still be eligible for a discount, but we can’t verify your age",
-    );
-  });
-
-  it("Validates an invalid number/id field", () => {
-    cy.get("#sub").type(users.invalidSub.sub);
-    cy.get("#name").type(users.invalidSub.name);
-    cy.get("input[type='submit']").click();
-
-    cy.contains("Check your input. The format looks wrong.");
-    cy.get("#id_sub").then(($e) => {
-      expect($e).to.have.css("border-color", "rgb(222, 12, 12)");
-    });
+    cy.contains("could not be verified");
   });
 
   it("Validates an empty name field", () => {
-    cy.get("#sub").type(users.invalidSub.sub);
-    cy.get("input[type='submit']").click();
+    cy.get("#sub").type(users.eligible.sub);
+    cy.get("#form-eligibility-verification button[type='submit']").click();
 
     cy.get("input:invalid").should("have.length", 1);
   });

tests/cypress/specs/feature/rate-limit.cy.js

@@ -4,13 +4,22 @@ const { eligibility_url, post_confirm } = require("../../plugins/eligibility");
 
 describe("Rate limiting feature spec", () => {
   beforeEach(() => {
-    cy.visit("/" + agencies[0].fields.slug);
-    cy.visit(eligibility_url);
+    cy.visit("/");
+
+    // agency selection
+    cy.contains("Choose Your Provider").click();
+    cy.contains(agencies[0].fields.long_name).click();
+
+    // select Courtesy Card
+    // TODO find a more robust way to do this
+    cy.get('#form-verifier-selection [type="radio"]').check("2");
+    cy.get("#form-verifier-selection button[type='submit']").click();
+    cy.contains("Continue").click();
   });
 
   it("Limits excess requests", () => {
-    const sub = users.invalidSub.sub;
-    const name = users.invalidSub.name;
+    const sub = users.ineligible.sub;
+    const name = users.ineligible.name;
 
     // start by making 5 times as many requests as allowed
     const RATE_LIMIT = Cypress.env("DJANGO_RATE_LIMIT");