chore(viewmodels): remove unused fields from MediaItem

refactored into the Start page templates directly
cal-itp · Jul 7, 2023 · fdf8479 · fdf8479
1 parent 57f083e
commit fdf8479
Show file tree

Hide file tree

Showing 5 changed files with 1 addition and 34 deletions.
diff --git a/benefits/core/migrations/0001_initial.py b/benefits/core/migrations/0001_initial.py
@@ -36,7 +36,6 @@ class Migration(migrations.Migration):
             name="EligibilityVerifier",
             fields=[
                 ("id", models.AutoField(primary_key=True, serialize=False)),
-                ("bullets", models.JSONField(null=True)),
                 ("name", models.TextField()),
                 ("api_url", models.TextField(null=True)),
                 ("api_auth_header", models.TextField(null=True)),

diff --git a/benefits/core/migrations/0002_data.py b/benefits/core/migrations/0002_data.py
@@ -149,11 +149,6 @@ def load_data(app, *args, **kwargs):
 
     mst_oauth_claims_verifier = EligibilityVerifier.objects.create(
         name=os.environ.get("MST_OAUTH_VERIFIER_NAME", "OAuth claims via Login.gov (MST)"),
-        bullets=[
-            "eligibility.pages.start.login_gov.required_items[0]",
-            "eligibility.pages.start.login_gov.required_items[1]",
-            "eligibility.pages.start.login_gov.required_items[2]",
-        ],
         eligibility_type=mst_senior_type,
         auth_provider=senior_auth_provider,
         selection_label=_("eligibility.pages.index.login_gov.label"),
@@ -172,12 +167,6 @@ def load_data(app, *args, **kwargs):
 
     mst_veteran_verifier = EligibilityVerifier.objects.create(
         name=os.environ.get("MST_VETERAN_VERIFIER_NAME", "VA.gov - Veteran (MST)"),
-        bullets=[
-            "eligibility.pages.start.veteran.required_items[0]",
-            "eligibility.pages.start.veteran.required_items[1]",
-            "eligibility.pages.start.veteran.required_items[2]",
-            "eligibility.pages.start.veteran.required_items[3]",
-        ],
         eligibility_type=mst_veteran_type,
         auth_provider=veteran_auth_provider,
         selection_label=_("eligibility.pages.index.veteran.label"),
@@ -228,11 +217,6 @@ def load_data(app, *args, **kwargs):
 
     sacrt_oauth_claims_verifier = EligibilityVerifier.objects.create(
         name=os.environ.get("SACRT_OAUTH_VERIFIER_NAME", "OAuth claims via Login.gov (SacRT)"),
-        bullets=[
-            "eligibility.pages.start.login_gov.required_items[0]",
-            "eligibility.pages.start.login_gov.required_items[1]",
-            "eligibility.pages.start.login_gov.required_items[2]",
-        ],
         eligibility_type=sacrt_senior_type,
         auth_provider=senior_auth_provider,
         selection_label=_("eligibility.pages.index.login_gov.label"),

diff --git a/benefits/core/models.py b/benefits/core/models.py
@@ -86,7 +86,6 @@ class EligibilityVerifier(models.Model):
     """An entity that verifies eligibility."""
 
     id = models.AutoField(primary_key=True)
-    bullets = models.JSONField(null=True)
     name = models.TextField()
     api_url = models.TextField(null=True)
     api_auth_header = models.TextField(null=True)

diff --git a/benefits/core/templates/core/includes/media-list.html b/benefits/core/templates/core/includes/media-list.html
@@ -7,16 +7,8 @@
                 {% if item.details|length %}
                     <div class="media-body--details">
                         {% for d in item.details %}<p>{{ d }}</p>{% endfor %}
-                        {% if item.bullets|length %}
-                            <div class="media-body--items">
-                                <ul>
-                                    {% for l in item.bullets %}<li>{{ l }}</li>{% endfor %}
-                                </ul>
-                            </div>
-                        {% endif %}
                     </div>
                 {% endif %}
-                {% if item.secondary_details %}<p class="pt-1">{{ item.secondary_details }}</p>{% endif %}
             </div>
         </li>
     {% endfor %}

diff --git a/benefits/core/viewmodels.py b/benefits/core/viewmodels.py
@@ -101,12 +101,10 @@ class MediaItem:
     Represents a media item in a list of items:
     * icon: core.viewmodels.Icon
     * details: str, str[]
-    * secondary_details: str
     * heading: str
-    * bullets: str, str[]
     """
 
-    def __init__(self, icon: Icon, details, secondary_details=None, heading=None, bullets=None):
+    def __init__(self, icon: Icon, details, heading=None):
         self.icon = icon
         if isinstance(details, str):
             self.details = [details]
@@ -115,11 +113,6 @@ def __init__(self, icon: Icon, details, secondary_details=None, heading=None, bu
         else:
             self.details = [str(details)]
         self.heading = heading
-        self.secondary_details = secondary_details
-        if isinstance(bullets, str):
-            self.bullets = [bullets]
-        elif isinstance(bullets, list):
-            self.bullets = bullets
 
 
 class Modal: