Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve secrets management #1163

Closed
6 of 9 tasks
afeld opened this issue Dec 15, 2022 · 2 comments · Fixed by #1198
Closed
6 of 9 tasks

Improve secrets management #1163

afeld opened this issue Dec 15, 2022 · 2 comments · Fixed by #1198
Assignees
Labels
chore Chores and tasks for code cleanup, dev experience, admin/configuration settings, etc.

Comments

@afeld
Copy link
Contributor

afeld commented Dec 15, 2022

In #1143, we determined that we want to go from the data migration file being treated as one big secret to the file loading secrets it needs at runtime (e.g. as environment variables).

Acceptance Criteria

  • We are managing secrets as individual values rather than all in one file
  • We minimize the number of places that secrets are stored
  • Secrets are stored in a secure location

Tasks

Additional context

See #1143 and #1116 for more context on past situations that motivated this refactor.

@afeld afeld added the chore Chores and tasks for code cleanup, dev experience, admin/configuration settings, etc. label Dec 15, 2022
@thekaveman thekaveman changed the title move migration file into repo Update data migrations to read from environment Dec 15, 2022
@angela-tran angela-tran self-assigned this Jan 12, 2023
@angela-tran
Copy link
Member

Talked with @thekaveman about working on this while we wait for #1090. The first part will be to update our data migration file to read environment variables.

@thekaveman thekaveman added this to the Reliability milestone Jan 13, 2023
@angela-tran angela-tran changed the title Update data migrations to read from environment Improve secrets management Feb 15, 2023
@thekaveman
Copy link
Member

Moved description into Milestone, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chores and tasks for code cleanup, dev experience, admin/configuration settings, etc.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants