Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update focus ring #1387

Closed
1 task
vykster opened this issue May 2, 2023 · 5 comments · Fixed by #1633
Closed
1 task

Update focus ring #1387

vykster opened this issue May 2, 2023 · 5 comments · Fixed by #1633
Assignees
Labels
design UX/UI research and tasks: Figma front-end HTML/CSS/JavaScript and Django templates user story Description of a new feature from the user's perspective, with acceptance criteria

Comments

@vykster
Copy link
Member

vykster commented May 2, 2023

Improve UI of default browser for focus ring, make a bold yellow.

image

Acceptance criteria

  • When user moves between components next item is highlight with new focus style

Links to user research, designs and resources

@vykster vykster added the user story Description of a new feature from the user's perspective, with acceptance criteria label May 2, 2023
@machikoyasuda machikoyasuda added the front-end HTML/CSS/JavaScript and Django templates label May 2, 2023
@thekaveman thekaveman added this to the Veterans milestone Jul 27, 2023
@machikoyasuda
Copy link
Member

Hey @srhhnry, I started looking at the designs for this ticket b/c I wanted to get all my questions to you before you start your leave.

I see that the Figma designs show examples of the focus ring on:

  • text link (including external links, footer and modal links)
  • certain buttons (Previous Page button, Login.gov modal button, modal close X button)

But there are no focus ring examples for:

  • standard primary blue button (like Continue, Go back, Spanish, etc.)
  • radio input (Eligibility form)
  • text input (Courtesy Card form)
  • agency selector

These all currently have the browser standard light blue focus rings:
image
image
image
image
image
image

Were the omission of the primary action button, Español button, agency selector radio input and text input intentional? Or should the same yellow focus ring design be applied to those as well?

@srhhnry
Copy link
Member

srhhnry commented Aug 3, 2023

Omission was not intentional! Just my own lack of understanding that aspect of accessibility. I'll mock those elements up either Friday (tomorrow) or next week (and am adding design to this issue for easier tracking).

  • standard primary blue button (like Continue, Go back, Spanish, etc.)
  • radio input (Eligibility form)
  • text input (Courtesy Card form)
  • agency selector
  • español

@srhhnry srhhnry added the design UX/UI research and tasks: Figma label Aug 3, 2023
@srhhnry srhhnry self-assigned this Aug 3, 2023
@srhhnry
Copy link
Member

srhhnry commented Aug 4, 2023

Focus ring is updated on all those components^ if that all looks good I think we can close this ticket @machikoyasuda

@machikoyasuda
Copy link
Member

@srhhnry Figma updates look good! The only thing is, as I mentioned on Slack, the focus ring border radiuses must match that of the element itself. If you're comfortable with that, I can implement the design with the 3px/2px #FDB714 ring with matching border-radiuses.

@srhhnry
Copy link
Member

srhhnry commented Aug 9, 2023

Yes, definitely comfortable with that. But I also feel like I'm missing something--border radius (aka corner radius in Figma) is set to 8px for both the component and the focus ring. Is there another difference you're seeing? I'm curious about the translation to CSS.

This was referenced Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design UX/UI research and tasks: Figma front-end HTML/CSS/JavaScript and Django templates user story Description of a new feature from the user's perspective, with acceptance criteria
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants