-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update focus ring #1387
Comments
Hey @srhhnry, I started looking at the designs for this ticket b/c I wanted to get all my questions to you before you start your leave. I see that the Figma designs show examples of the focus ring on:
But there are no focus ring examples for:
These all currently have the browser standard light blue focus rings: Were the omission of the primary action button, Español button, agency selector radio input and text input intentional? Or should the same yellow focus ring design be applied to those as well? |
Omission was not intentional! Just my own lack of understanding that aspect of accessibility. I'll mock those elements up either Friday (tomorrow) or next week (and am adding design to this issue for easier tracking).
|
Focus ring is updated on all those components^ if that all looks good I think we can close this ticket @machikoyasuda |
@srhhnry Figma updates look good! The only thing is, as I mentioned on Slack, the focus ring border radiuses must match that of the element itself. If you're comfortable with that, I can implement the design with the 3px/2px |
Yes, definitely comfortable with that. But I also feel like I'm missing something--border radius (aka corner radius in Figma) is set to 8px for both the component and the focus ring. Is there another difference you're seeing? I'm curious about the translation to CSS. |
Improve UI of default browser for focus ring, make a bold yellow.
Acceptance criteria
Links to user research, designs and resources
The text was updated successfully, but these errors were encountered: