New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LittlePay Modal #1516
LittlePay Modal #1516
Conversation
…trigger link style
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CSS here looks good, and I'm glad to see the refactor from #1504 was helpful here!
My only comment is that I think modal-info.html
and modal.html
are similar enough to where they could be one file.
</div> | ||
</div> | ||
</div> | ||
{% endwith %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code is pretty similar to modal.html
. The only differences are size
on line 4 and some spacing (p-2
on line 6, pt-0 mt-0 p-4 m-2
on line 9).
It might be worth it to find a way to make them one file. It doesn't necessarily have to be in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely can be done in a future PR!
closes #1481
What this PR does
button
, but has the styles of a default text linkDocumentation
Modal Trigger Link
id
,classes
,text
"modal-trigger--link"
for an inline link (but actually button on the inside) with the (?) around it. (The reason why it has to be a button is so that the modal opens when focused and a user clicks spacebar or the enter key).Modal Info
size
-modal-lg
ormodal-md
(classes from Bootstrap)modal-lg
ormodal-md
Modal