Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define EligibilityVerifier for veterans #1427

Closed
thekaveman opened this issue Jun 12, 2023 · 3 comments · Fixed by #1436
Closed

Define EligibilityVerifier for veterans #1427

thekaveman opened this issue Jun 12, 2023 · 3 comments · Fixed by #1436
Assignees

Comments

@thekaveman
Copy link
Member

thekaveman commented Jun 12, 2023

This model holds references to most of the content that is displayed for the Veterans flow. Focus on English copy only for the basic/existing UI (i.e. no modals etc.)

@thekaveman thekaveman added this to the Veterans milestone Jun 12, 2023
@machikoyasuda
Copy link
Member

@machikoyasuda
Copy link
Member

machikoyasuda commented Jun 21, 2023

@thekaveman Should this issue also update the copy for the highlighted bulleted section?

image

This bulleted section's copy is not stored in EligibilityVerifier, it's called in

if verifier.is_auth_required:
if verifier.uses_auth_verification:
identity_item.bullets = [
_("eligibility.pages.start.login_gov.required_items[0]"),
_("eligibility.pages.start.login_gov.required_items[1]"),
_("eligibility.pages.start.login_gov.required_items[2]"),
]

I think it should be covered in a separate issue and PR, b/c there's a bit going on.

@thekaveman
Copy link
Member Author

I think it should be covered in a separate issue and PR, b/c there's a bit going on.

That sounds good,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants