Veterans - Eligibility Verifier + Eligibility Type

[machikoyasuda]

closes #1427
closes #1426

What this PR does

• Create EligibilityVerifier for MST Veterans
• Create EligibilityType for MST Veterans
• Create Terraform values stubs for: "MST_VETERAN_GROUP_ID", "MST_VETERAN_VERIFIER_NAME"
• Spec: Update benefit-select.cy.js spec from looking for 2 radio inputs, to 3 inputs. Update Cypress helper method so it correctly chooses Courtesy Card radio button.
• Copy: Eligibility Index page and add VA.gov url as well (but not the new external link icon design).
• Copy: Enrollment Success page - Same as Login.gov
• Copy: Eligibility Start page: 2 paragraphs (except for the required_items bullet list - that's not part of EligibilityVerifier)
• UI: Eligibility Index page - Make sure US Veteran option is the 2nd choice.
• Define EligibilityType for veterans #1426

What configuration has been done

• Update KeyVault development for EligibilityVerifier: Create and set these key/values
• Update KeyVault test for EligibilityVerifier: Create and set these key/values
• Create Veteran group in LittlePay
• Update KeyVault development for EligibilityType
• Update KeyVault test for EligibilityVerifier

Screenshots

Documentation

EligibilityVerifier model

• Adds start_item_secondary_details, an optional TextField(), to EligibilityVerifier model

MediaItem viewmodel

• Adds secondary_details, an optional string, to MediaItem viewmodel class

The secondary_details is this details paragraph that comes after the bullets, on the Eligibility Start page.

Notes

On Production, after going through the Login.gov flow and verifying eligibility, the user sees the enrollment screen with this copy, consisting of 2 media items:

In the new design, however, there is only 1 media item for all enrollment screens, and the remaining media item for Little Pay is also shortened from 2 paragraphs to 1:

[machikoyasuda]

@thekaveman @angela-tran I'm blocked here: #1437 Do you see any syntax error or something I'm doing wrong?

Update: Not blocked anymore.

[angela-tran]

These changes look good to me @machikoyasuda! I'm inclined to approve, but would like to get others' feedback about the PO entry naming / consolidation. Maybe at the very least we can remove login_gov from that PO entry msgid and leave the Courtesy Card verifier alone for now.

[machikoyasuda]

@thekaveman @angela-tran Ready for re-review, hopefully final review. I added a few changes since the last review from Angela:

1. The copy on Eligibility Start was off by one word.
2. Removed login_gov from msgids for Unverified page, b/c all the Unverified pages have the same copy now.
3. Added VA.gov link (which required adding format_html() code)

I also added these secrets to KeyVault dev:

stubbed with fake value

[thekaveman]

Please update the description to also note that this PR closes #1426

Otherwise this looks good and can be approved once the Test KeyVault secrets are created!

Accidental approval

[angela-tran]

@machikoyasuda To clarify on this PR also closing #1426, have you created the LP group yet?

[machikoyasuda]

@angela-tran No not yet.

This is my current status:

[machikoyasuda]

• Created MST Veteran group on QA (Documented here https://github.com/cal-itp/benefits-secrets/pull/36)
• Updated KeyVault Dev with the new group id
• Updated KeyVault Test with the new group id and the verifier name

@angela-tran @thekaveman

Ready for final...final 😅 ...review, to confirm that this PR can be merged to close 2 issues (#1427 #1426).

[angela-tran]

Looks good to me @machikoyasuda 👍

[thekaveman]

Ah @machikoyasuda I was still reviewing this!

[thekaveman]

Why did we lose our Issues link here?

[thekaveman]

It looks like the helper bin/makemessages.sh was not run, it is supposed to put this line back.

[machikoyasuda]

@thekaveman Oops sorry!!! 😓

I just noticed I get this error after running bin/makemessages.sh now:

calitp@cdbe8faf8c05:~/app$ bin/makemessages.sh
processing locale es
processing locale en
sed: couldn't open temporary file benefits/locale/en/LC_MESSAGES/sed3E0pRF: Permission denied

which fails when running sed -i 's/Report-Msgid-Bugs-To\:/Report-Msgid-Bugs-To\: https\:\/\/github.com\/cal-itp\/benefits\/issues/g' benefits/locale/*/*/*.po - so that's why that line failed to get changed.

[machikoyasuda]

Reported here: #1455