Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor common strings out of EligibilityVerifier #1449

Closed
2 tasks
thekaveman opened this issue Jun 26, 2023 · 0 comments · Fixed by #1531
Closed
2 tasks

Refactor common strings out of EligibilityVerifier #1449

thekaveman opened this issue Jun 26, 2023 · 0 comments · Fixed by #1531

Comments

@thekaveman
Copy link
Member

With the Veteran's work and copy updates, we've gone back to a single "Unverified" page design and copy, meaning we don't need per-flow copy changes like EligibilityVerifier.unverified_title and EligibilityVerifier.unverified_blurb.

In an effort to simplify our page building (see also #1442), let's move these common fields out of our models and into the page templates directly.

Acceptance Criteria

  • unverified_title and unverified_blob fields are removed from the EligibilityVerifier model
  • the unverified.html template directly renders the necessary (translated) content.

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant