Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Eligibility unverified page #1531

Merged
merged 2 commits into from Jul 17, 2023
Merged

Refactor: Eligibility unverified page #1531

merged 2 commits into from Jul 17, 2023

Conversation

thekaveman
Copy link
Member

@thekaveman thekaveman commented Jul 13, 2023 •
edited

Closes #1449
Closes #1520

English
Desktop image
Mobile image

Spanish
Desktop image
Mobile image

No sign out link
Desktop image
Mobile image

@thekaveman thekaveman added this to the Veterans milestone Jul 13, 2023
@thekaveman thekaveman self-assigned this Jul 13, 2023
@github-actions github-actions bot added migrations [auto] Review for potential model changes/needed data migrations updates back-end Django views, sessions, middleware, models, migrations etc. i18n Copy: Language files or Django i18n framework front-end HTML/CSS/JavaScript and Django templates tests Related to automated testing (unit, UI, integration, etc.) deployment-dev [auto] Changes that will trigger a deploy if merged to dev and removed back-end Django views, sessions, middleware, models, migrations etc. i18n Copy: Language files or Django i18n framework tests Related to automated testing (unit, UI, integration, etc.) front-end HTML/CSS/JavaScript and Django templates labels Jul 13, 2023
@thekaveman thekaveman force-pushed the refactor/eligibility-unverified branch from c761a46 to 6b0af9e Compare July 13, 2023 23:23
@thekaveman thekaveman changed the base branch from dev to fix/naming July 13, 2023 23:24
Base automatically changed from fix/naming to dev July 14, 2023 16:30
@thekaveman thekaveman force-pushed the refactor/eligibility-unverified branch from 6b0af9e to 594834e Compare July 14, 2023 16:41
@thekaveman thekaveman mentioned this pull request Jul 14, 2023
Merged
@thekaveman thekaveman force-pushed the refactor/eligibility-unverified branch from 594834e to f78026b Compare July 14, 2023 20:01
@thekaveman thekaveman changed the base branch from dev to refactor/sign-out July 14, 2023 20:01
@thekaveman thekaveman force-pushed the refactor/eligibility-unverified branch from f78026b to 7556a56 Compare July 14, 2023 20:21
@thekaveman thekaveman force-pushed the refactor/eligibility-unverified branch from 7556a56 to f99416a Compare July 14, 2023 20:43
@thekaveman
refactor(unverified): title, headline
fe36fb5 
port the existing paragraph
@thekaveman thekaveman force-pushed the refactor/eligibility-unverified branch from f99416a to f4ddc2f Compare July 14, 2023 20:58
Base automatically changed from refactor/sign-out to dev July 14, 2023 21:01
@thekaveman
refactor(unverified): paragraph
1b258c4 
use agency.short_name from context
@thekaveman thekaveman force-pushed the refactor/eligibility-unverified branch from f4ddc2f to 1b258c4 Compare July 14, 2023 21:08
@thekaveman thekaveman marked this pull request as ready for review July 14, 2023 21:17
@thekaveman thekaveman requested a review from a team as a code owner July 14, 2023 21:17
angela-tran
angela-tran approved these changes Jul 14, 2023
View reviewed changes
Copy link
Member

@angela-tran angela-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@thekaveman thekaveman merged commit 77dfe5e into dev Jul 17, 2023
11 checks passed
@thekaveman thekaveman deleted the refactor/eligibility-unverified branch July 17, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angela-tran angela-tran angela-tran approved these changes

Assignees

@thekaveman thekaveman

Labels
back-end Django views, sessions, middleware, models, migrations etc. deployment-dev [auto] Changes that will trigger a deploy if merged to dev i18n Copy: Language files or Django i18n framework migrations [auto] Review for potential model changes/needed data migrations updates
Projects
None yet
Milestone
Veteran rider enrollment pathway
Development

Successfully merging this pull request may close these issues.

Eligibility Unverified - Update copy, refactor Refactor common strings out of EligibilityVerifier
2 participants
@thekaveman @angela-tran