Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External Link Icon - Add external link icon to Footer link(s) #1471

Closed
thekaveman opened this issue Jul 3, 2023 · 1 comment · Fixed by #1540
Closed

External Link Icon - Add external link icon to Footer link(s) #1471

thekaveman opened this issue Jul 3, 2023 · 1 comment · Fixed by #1540
Assignees

Comments

@thekaveman
Copy link
Member

No description provided.

@thekaveman thekaveman added this to the Veterans milestone Jul 3, 2023
@machikoyasuda machikoyasuda changed the title Add external link icon to Footer link(s) External Link Icon - Add external link icon to Footer link(s) Jul 5, 2023
@angela-tran angela-tran self-assigned this Jul 17, 2023
@angela-tran
Copy link
Member

Apparently, only some properties can be styled for the :visited pseudo-class selector (see this CSS-tricks article). This means that we can't just specify the background-image to use for a visited link.

This issue is more obvious with the footer links since they are a elements as opposed to our modal triggers which are buttons styled as links.

Compare visited a vs. visited button

image

image

I found a StackOverflow post with some links to ways to hack around :visited, but maybe we should discuss with the design team on what to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
2 participants