-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Remove unused form error-handling; add new placeholder + regex #1022
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran through the CC flow for:
- Input that doesn't match the regex ✅
- Input that is verified ✅
- Input that is not verified ✅
It all looks good; maybe we can clean the spacing up later.
@thekaveman Yea - on spacing, this next PR #1023 would be the best time and place to change the Form template spacing. As far as I can tell, the linters don't do anything for anything in between |
this should've been removed in #1022
this should've been removed in #1022
this should've been removed in #1022
this should've been removed in #1022
closes #1007
What this PR does
with-errors
related HTML, CSS, JS and Python methodHow to test
./bin/init.sh
to get the new sample data regex/input placeholder