Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove unused form error-handling; add new placeholder + regex #1022

Merged
merged 6 commits into from
Oct 6, 2022

Conversation

machikoyasuda
Copy link
Member

@machikoyasuda machikoyasuda commented Oct 5, 2022

closes #1007

What this PR does

  • Remove form with-errors related HTML, CSS, JS and Python method
  • Add sample placeholder and regex

How to test

  • Run ./bin/init.sh to get the new sample data regex/input placeholder
  • Go through both forms and ensure no regressions in style and function
  • Go through Input form: Test an input that fails the regex

image

@machikoyasuda machikoyasuda requested a review from a team as a code owner October 5, 2022 23:02
@machikoyasuda machikoyasuda self-assigned this Oct 5, 2022
@machikoyasuda machikoyasuda added this to the Courtesy Cards milestone Oct 5, 2022
@github-actions github-actions bot added back-end Django views, sessions, middleware, models, migrations etc. migrations [auto] Review for potential model changes/needed data migrations updates tests Related to automated testing (unit, UI, integration, etc.) front-end HTML/CSS/JavaScript and Django templates deployment-dev [auto] Changes that will trigger a deploy if merged to dev and removed migrations [auto] Review for potential model changes/needed data migrations updates labels Oct 5, 2022
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran through the CC flow for:

  1. Input that doesn't match the regex ✅
  2. Input that is verified ✅
  3. Input that is not verified ✅

It all looks good; maybe we can clean the spacing up later.

@machikoyasuda machikoyasuda merged commit bcf1459 into dev Oct 6, 2022
@machikoyasuda machikoyasuda deleted the feat/1007-form--remove-with-errors--again branch October 6, 2022 17:37
@machikoyasuda
Copy link
Member Author

@thekaveman Yea - on spacing, this next PR #1023 would be the best time and place to change the Form template spacing. As far as I can tell, the linters don't do anything for anything in between <script>....</script> on these pages. For now, I'm just making sure the if/elses and open/close elements are all aligned.

angela-tran added a commit that referenced this pull request Apr 23, 2024
this should've been removed in #1022
angela-tran added a commit that referenced this pull request Apr 23, 2024
this should've been removed in #1022
angela-tran added a commit that referenced this pull request Apr 25, 2024
this should've been removed in #1022
angela-tran added a commit that referenced this pull request Apr 25, 2024
this should've been removed in #1022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back-end Django views, sessions, middleware, models, migrations etc. deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates tests Related to automated testing (unit, UI, integration, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unused form with-errors logic/code
2 participants