fix(CI): send API check failure notifications to Slack #1184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is really cool! But one note, the payments team is probably interested in a different API than what our check is for. They use some kind of export/bulk transactions API, whereas Benefits uses the Customer API. |
afeld
force-pushed
the
fix/api-notification
branch
from
2fcb289
to
6e79190
Compare
|
Triggered a failure in 2fcb289 and they showed up in Slack, so it works! Ready for review. |
angela-tran
approved these changes
Jan 9, 2023
There was a problem hiding this comment.
Nice! Also, for more context, the only reason why we didn't have this already is because when #252 was worked on, we had a limited amount of Slack app integrations for Cal-ITP and had used them all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was looking at #832 (comment) after the Payments Data team also came up with the failure scenario of the Littlepay API being down, and I realized this would be easy to resolve.
SLACK_WEBHOOK_URLin Actions secrets