Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: parameterize messages with agency-specific content #1196

Merged
merged 5 commits into from
Jan 12, 2023
Merged

Refactor: parameterize messages with agency-specific content #1196

merged 5 commits into from
Jan 12, 2023

Commits on Jan 11, 2023

  1. refactor: parameterize enrollment index message with agency short name

    @angela-tran
    angela-tran committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    081f436 View commit details
    Browse the repository at this point in the history

  2. refactor: parameterize eligibility index message with agency short name

    @angela-tran
    angela-tran committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    4ae331b View commit details
    Browse the repository at this point in the history

  3. fix: the eligibility index English copy needs more than just short name 

    extract out the part that needs to vary ("an" vs. "a" if the agency's
name starts with a vowel sound or not)
    @angela-tran
    angela-tran committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    7df9e31 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2023

  1. refactor: use more straightforward approach of storing full sentence

    @angela-tran
    angela-tran committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    4b6b150 View commit details
    Browse the repository at this point in the history

  2. fix: handle case where agency.eligibility_index_intro is not a string 

    this is to address the test failure and also is a valid case
    @angela-tran
    angela-tran committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    b5c0fe9 View commit details
    Browse the repository at this point in the history