Chore: always show the user the eligibility index #1201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
back-end
angela-tran
added
the
back-end
thekaveman
approved these changes
Jan 13, 2023
There was a problem hiding this comment.
Looks great. I tested locally with an agency that only has 1 verifier, and saw the /eligibility page with verifier selection as expected ✅
Sidebar
At first I had a few failing tests in eligibility/views:
Notice all the failures are for POST view handlers
Debugging I saw that it was the reCAPTCHA check failing - I had it turned on locally in my .env file. Once I turned that off, these tests passed.
Maybe we should create a follow-up issue to address this with a @pytest.mark or something, to ensure reCAPTCHA is disabled for tests that will fail otherwise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1200
Unit test was updated and passes. To test in the browser, update your sample data so that
mst_agencyonly has one verifier.