Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: agency selection backend #1204

Merged
merged 3 commits into from Jan 18, 2023
Merged

Refactor: agency selection backend #1204

merged 3 commits into from Jan 18, 2023

Conversation

angela-tran
Copy link
Member

@angela-tran angela-tran commented Jan 13, 2023 •
edited

Back-end changes for #1197 - see the approach outlined in this comment

This PR also adds a sample SacRT transit agency to the data migration.

@angela-tran angela-tran self-assigned this Jan 13, 2023
@github-actions github-actions bot added migrations [auto] Review for potential model changes/needed data migrations updates deployment-dev [auto] Changes that will trigger a deploy if merged to dev back-end Django views, sessions, middleware, models, migrations etc. i18n Copy: Language files or Django i18n framework labels Jan 13, 2023
@angela-tran angela-tran force-pushed the refactor/agency-selection-backend branch from 856013f to f92f9e5 Compare January 13, 2023 19:23
@angela-tran angela-tran force-pushed the refactor/agency-selection-backend branch from 34ff69f to 31c1141 Compare January 13, 2023 21:19
@angela-tran angela-tran marked this pull request as ready for review January 18, 2023 16:58
@angela-tran angela-tran requested a review from a team as a code owner January 18, 2023 16:58
@angela-tran
Copy link
Member Author

Need to make some small changes to the view logic that I changed. Putting back in draft

@angela-tran angela-tran marked this pull request as draft January 18, 2023 18:32
@angela-tran angela-tran force-pushed the refactor/agency-selection-backend branch from 31c1141 to 8c388c6 Compare January 18, 2023 18:38
@angela-tran angela-tran marked this pull request as ready for review January 18, 2023 18:38
machikoyasuda
machikoyasuda approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@machikoyasuda machikoyasuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! ran migration and tested locally

@angela-tran angela-tran merged commit dd22bba into dev Jan 18, 2023
@angela-tran angela-tran deleted the refactor/agency-selection-backend branch January 18, 2023 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machikoyasuda machikoyasuda machikoyasuda approved these changes

Assignees

@angela-tran angela-tran

Labels
back-end Django views, sessions, middleware, models, migrations etc. deployment-dev [auto] Changes that will trigger a deploy if merged to dev i18n Copy: Language files or Django i18n framework migrations [auto] Review for potential model changes/needed data migrations updates
Projects
None yet
Milestone
SacRT Older Adults
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@angela-tran @machikoyasuda