Dynamic localhost ports #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
defining just the internal container ports allows Docker to dynamically assign the corresponding localhost ports when a container is run
docs/getting-started/README.md
Outdated
|
|
||
| If `DJANGO_ADMIN=true`, the backend administrative interface can be accessed with the superuser you setup at | ||
| <http://localhost:8000/admin>. | ||
| After initialization, the client is running running on `http://localhost` at a port dynamically assigned by Docker. To find the |
There was a problem hiding this comment.
What the Docker Desktop interface looks like: Click Containers / Apps,
Find $PORT at http://0.0.0.0:56760/ or http://localhost:56760/
or at
| From within another Compose service container, the API is at `http://server:5000` using the service-forwarding features of | ||
| Compose. | ||
|
|
||
| In either case, the endpoint `/verify` serves as the Eligibility Verification API endpoint. |
There was a problem hiding this comment.
-
I am able to successfully build and run
docker compose build server,docker compose up server -
Note: This log might be confusing to users because the
* Running on http://172.26.0.3:5000/is now incorrect
-
When I run the Docker app and the
docker pscommand, I see that the port is assigned to57463:
-
When I have both the server and client running via docker-compose, I am able to go through a successful verification flow:
fixes an issue with docs being unable to start locally with e.g.
$ docker compose up docs
use the same formatting on dev for consistency
machikoyasuda
approved these changes
Oct 1, 2021
add some screenshots for clarity normalize Dev Containter -> Devcontainer
thekaveman
force-pushed
the
dynamic-localhost-ports
branch
from
b160ef1
to
8c32e14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #123 by removing all hardcoded localhost ports and allowing Docker to assign dynamically.
Relevant docs updated to describe how to find the dynamic port for various situations.