Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: set up Sentry #1259

Merged
merged 8 commits into from Feb 15, 2023
Merged

chore: set up Sentry #1259

merged 8 commits into from Feb 15, 2023

Conversation

afeld
Copy link
Contributor

@afeld afeld commented Feb 11, 2023 •
edited

Part of #1258. Closes #733.

Adds Sentry error and performance monitoring. Sample Issue captured by Sentry.

Screenshot 2023-02-13 at 15-55-24 RuntimeError Test error - sentry - benefits

Doesn't touch the Azure Monitor integration.

@github-actions github-actions bot added docker Application container, devcontainer, Compose, etc. documentation [auto] Improvements or additions to documentation back-end Django views, sessions, middleware, models, migrations etc. infrastructure Terraform, Azure, etc. deployment-dev [auto] Changes that will trigger a deploy if merged to dev labels Feb 11, 2023
afeld
afeld commented Feb 11, 2023
View reviewed changes
benefits/sentry.py Outdated Show resolved Hide resolved
@afeld afeld marked this pull request as ready for review February 11, 2023 20:25
@afeld afeld requested a review from a team as a code owner February 11, 2023 20:25
@afeld afeld mentioned this pull request Feb 11, 2023
Merged
afeld
afeld commented Feb 13, 2023
View reviewed changes
benefits/urls.py Outdated Show resolved Hide resolved
thekaveman
thekaveman reviewed Feb 14, 2023
View reviewed changes
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall great PR and nice simple implementation!

Replied to some of your thoughts/comments, I think one small change that you suggested to the release config is warranted.

benefits/sentry.py Outdated Show resolved Hide resolved
benefits/urls.py Outdated Show resolved Hide resolved
thekaveman
thekaveman approved these changes Feb 14, 2023
View reviewed changes
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! I was able to configure Sentry locally, trigger the error, and see it show up in the dashboard:
image

@afeld afeld merged commit e11c2ff into dev Feb 15, 2023
@afeld afeld deleted the chore/sentry branch February 15, 2023 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thekaveman thekaveman thekaveman approved these changes

Assignees
No one assigned
Labels
back-end Django views, sessions, middleware, models, migrations etc. deployment-dev [auto] Changes that will trigger a deploy if merged to dev docker Application container, devcontainer, Compose, etc. documentation [auto] Improvements or additions to documentation infrastructure Terraform, Azure, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Send notifications for exceptions
2 participants
@afeld @thekaveman