Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: healthcheck user agents #1285

Merged
merged 4 commits into from
Feb 17, 2023
Merged

Fix: healthcheck user agents #1285

merged 4 commits into from
Feb 17, 2023

Conversation

angela-tran
Copy link
Member

@angela-tran angela-tran commented Feb 17, 2023

Redo of #1282

Closes #1276

This PR introduces a setting called HEALTHCHECK_USER_AGENTS which should be a comma-separated list of the user agents whose requests should always get a response of "Healthy" so that analytics are not sent.

Note that values with spaces need to be surrounded in double quotes when setting via environment variables.

@angela-tran angela-tran self-assigned this Feb 17, 2023
@angela-tran angela-tran requested a review from a team as a code owner February 17, 2023 19:00
@github-actions github-actions bot added back-end Django views, sessions, middleware, models, migrations etc. tests Related to automated testing (unit, UI, integration, etc.) and removed back-end Django views, sessions, middleware, models, migrations etc. labels Feb 17, 2023
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Nice simple implementation to allow us to force certain user agents to bypass our analytics.

Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry can we please update the version as well?

@angela-tran angela-tran mentioned this pull request Feb 17, 2023
12 tasks
@angela-tran angela-tran merged commit 921b95f into prod Feb 17, 2023
@angela-tran angela-tran deleted the fix/healthcheck-user-agents branch February 17, 2023 21:38
@github-actions github-actions bot added the deployment [auto] Pull requests that deploy to test or prod label Feb 17, 2023
@angela-tran angela-tran linked an issue Feb 21, 2023 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment [auto] Pull requests that deploy to test or prod tests Related to automated testing (unit, UI, integration, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't send events for healthchecks
2 participants