-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: healthcheck user agents #1285
Conversation
this is so no analytics are sent for these user agents.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍 Nice simple implementation to allow us to force certain user agents to bypass our analytics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry can we please update the version as well?
Redo of #1282
Closes #1276
This PR introduces a setting called
HEALTHCHECK_USER_AGENTS
which should be a comma-separated list of the user agents whose requests should always get a response of "Healthy" so that analytics are not sent.Note that values with spaces need to be surrounded in double quotes when setting via environment variables.