Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump sentry-sdk from 1.16.0 to 1.17.0 in /appcontainer #1325

Merged
merged 1 commit into from Mar 21, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 16, 2023

Bumps sentry-sdk from 1.16.0 to 1.17.0.

Release notes

Sourced from sentry-sdk's releases.

1.17.0

Various fixes & improvements

  • New: Monitor Celery Beat tasks with Sentry Cron Monitoring.

    With this feature you can make sure that your Celery beat tasks run at the right time and see if they where successful or not.

    Warning Cron Monitoring is currently in beta. Beta features are still in-progress and may have bugs. We recognize the irony. If you have any questions or feedback, please email us at crons-feedback@sentry.io, reach out via Discord (#cronjobs), or open an issue.

    Usage:

    # File: tasks.py
    from celery import Celery, signals
    from celery.schedules import crontab
    import sentry_sdk
    from sentry_sdk.crons import monitor
    from sentry_sdk.integrations.celery import CeleryIntegration
    1. Setup your Celery beat configuration
    app = Celery('mytasks', broker='redis://localhost:6379/0')
    app.conf.beat_schedule = {
    'set-in-beat-schedule': {
    'task': 'tasks.tell_the_world',
    'schedule': crontab(hour='10', minute='15'),
    'args': ("in beat_schedule set", ),
    },
    }
    2. Initialize Sentry either in celeryd_init or beat_init signal.
    #@​signals.celeryd_init.connect
    @​signals.beat_init.connect
    def init_sentry(**kwargs):
    sentry_sdk.init(
    dsn='...',
    integrations=[CeleryIntegration()],
    environment="local.dev.grace",
    release="v1.0.7-a1",
    )
    3. Link your Celery task to a Sentry Cron Monitor

... (truncated)

Changelog

Sourced from sentry-sdk's changelog.

1.17.0

Various fixes & improvements

  • New: Monitor Celery Beat tasks with Sentry Cron Monitoring.

    With this feature you can make sure that your Celery beat tasks run at the right time and see if they where successful or not.

    Warning Cron Monitoring is currently in beta. Beta features are still in-progress and may have bugs. We recognize the irony. If you have any questions or feedback, please email us at crons-feedback@sentry.io, reach out via Discord (#cronjobs), or open an issue.

    Usage:

    # File: tasks.py
    from celery import Celery, signals
    from celery.schedules import crontab
    import sentry_sdk
    from sentry_sdk.crons import monitor
    from sentry_sdk.integrations.celery import CeleryIntegration
    1. Setup your Celery beat configuration
    app = Celery('mytasks', broker='redis://localhost:6379/0')
    app.conf.beat_schedule = {
    'set-in-beat-schedule': {
    'task': 'tasks.tell_the_world',
    'schedule': crontab(hour='10', minute='15'),
    'args': ("in beat_schedule set", ),
    },
    }
    2. Initialize Sentry either in celeryd_init or beat_init signal.
    #@​signals.celeryd_init.connect
    @​signals.beat_init.connect
    def init_sentry(**kwargs):
    sentry_sdk.init(
    dsn='...',
    integrations=[CeleryIntegration()],
    environment="local.dev.grace",
    release="v1.0.7-a1",
    )

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [sentry-sdk](https://github.com/getsentry/sentry-python) from 1.16.0 to 1.17.0.
- [Release notes](https://github.com/getsentry/sentry-python/releases)
- [Changelog](https://github.com/getsentry/sentry-python/blob/master/CHANGELOG.md)
- [Commits](getsentry/sentry-python@1.16.0...1.17.0)

---
updated-dependencies:
- dependency-name: sentry-sdk
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from a team as a code owner March 16, 2023 22:01
@dependabot dependabot bot added the dependencies [auto] Pull requests that update 3rd party software libraries and requirements label Mar 16, 2023
@thekaveman
Copy link
Member

thekaveman commented Mar 17, 2023

@angela-tran the terraform plan failed here, message is a 403 on trying to access the keyvault (specifically for the slack-benefits-notify-email secret): https://calenterprise.visualstudio.com/CDT.OET.CAL-ITP/_build/results?buildId=39935&view=logs&j=5af648c4-4294-55a7-6072-dd70820d3dba&t=42899ae2-6397-58a2-7641-cec3214b180b&l=35

Any idea what could be wrong here? #1318 ran at almost the same time as was fine?

@angela-tran
Copy link
Member

angela-tran commented Mar 17, 2023

@thekaveman Hmm, yeah I'm not sure what changed to cause this error to start showing. #1314 just started failing today on terraform plan as well. I manually re-ran the pipeline for #1318 too, and it failed (https://calenterprise.visualstudio.com/CDT.OET.CAL-ITP/_build/results?buildId=39962&view=results).

@angela-tran
Copy link
Member

I've found a lead on why this started failing. Someone from CDT set up IP address restrictions on our dev and test Key Vaults. (You can see this by looking at the Activity Log for the Key Vaults, filtering on last week.)

This article supports my theory since it shows the same error message and matches the behavior where a different IP address is being used by the pipeline and is therefore blocked every time.

@angela-tran
Copy link
Member

Here's an interesting StackOverflow discussion on a workaround... my guess though is that we don't want to have to do it this way.

https://stackoverflow.com/questions/57940062/azure-devops-build-pipeline-cant-get-secrets-from-key-vault-when-secured-with-v

@angela-tran angela-tran self-assigned this Mar 21, 2023
Copy link
Member

@angela-tran angela-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this upgrade locally - Sentry alert sent successfully and went through Login.gov flow and Courtesy Card flow

@angela-tran angela-tran merged commit 44616ea into dev Mar 21, 2023
9 checks passed
@angela-tran angela-tran deleted the dependabot/pip/appcontainer/sentry-sdk-1.17.0 branch March 21, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies [auto] Pull requests that update 3rd party software libraries and requirements
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants