Improve Docker build in deployment workflows #135
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
docker/setup-buildx-action
to setup a Docker Buildx builder for the jobdocker/build-push-action
instead of rawdocker
commands to build the imagedocker/build-push-action
's built-intype=gha
for GitHub ActionsTesting the PR
Forked over at https://github.com/thekaveman/benefits
Set up environment similar to this repository
Made a small modification to workflow to skip the actual deploy
Merged change (thekaveman/benefits#1) to see workflow run and succeed with new build steps (some output copied below):
Set up Docker Buildx
Build, tag, and push to Amazon ECR
Pushed one more small change to trigger the workflow one more time with layer caching! (some output copied below):
Build, tag, and push to Amazon ECR
More information
Should get us closer to #133
Closes #134
EDIT: Workflow run after this PR was merged showing new build process