Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Docker platform issue #1354

Merged
merged 4 commits into from Apr 13, 2023
Merged

Conversation

machikoyasuda
Copy link
Member

@machikoyasuda machikoyasuda commented Apr 10, 2023

fixes #1357 and cal-itp/eligibility-server#247

see #1353 in favor of this solution for background

Testing

How to test

  • Run bin/build.sh
  • Open VS Code and runRe-build without Cache and re-open in container
  • Wait for all extensions to install
  • Run the app in Debug mode
  • Try git status
  • Run commands, like pytest
  • Close VS Code
  • Open VS Code and run Re-open in container (using the cached dev container) and test steps again

@machikoyasuda machikoyasuda requested a review from a team as a code owner April 10, 2023 20:50
@github-actions github-actions bot added the docker Application container, devcontainer, Compose, etc. label Apr 10, 2023
@machikoyasuda machikoyasuda mentioned this pull request Apr 10, 2023
5 tasks
@thekaveman thekaveman self-requested a review April 10, 2023 21:49
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took me a few Dev Containers: Rebuild and Reopen in Container cycles to get the Python extension working correctly, but I don't think that has anything to do with these changes

👍

@thekaveman
Copy link
Member

@angela-tran can you please confirm these changes work for you before we merge?

Copy link
Member

@angela-tran angela-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thekaveman @machikoyasuda I can confirm that this works for me too. I was able to rebuild the base client image and rebuild the devcontainer.

At first, I got an error about EventScrubber not being found, but after rebuilding the client image, that went away. I guess my sentry_sdk version was off somewhere. Anyways, all good 👍

@machikoyasuda
Copy link
Member Author

@angela-tran Just out of curiosity, was the first VS Code container install slower for you?

@machikoyasuda machikoyasuda self-assigned this Apr 11, 2023
@machikoyasuda
Copy link
Member Author

Note: This PR closes this bug issue in Eligibility Server: cal-itp/eligibility-server#247

@machikoyasuda machikoyasuda merged commit dd3d8a0 into dev Apr 13, 2023
10 checks passed
@machikoyasuda machikoyasuda deleted the fix/docker-m1-compose-platform branch April 13, 2023 20:09
@angela-tran
Copy link
Member

@angela-tran Just out of curiosity, was the first VS Code container install slower for you?

Not that I remember 🤔 The first build always takes more time than subsequent ones that use cached layers I think, and it didn't stand out to me as taking longer than normal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker Application container, devcontainer, Compose, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Fix platform for Apple hardware
3 participants