New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Docker platform issue #1354
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took me a few Dev Containers: Rebuild and Reopen in Container
cycles to get the Python extension working correctly, but I don't think that has anything to do with these changes
👍
@angela-tran can you please confirm these changes work for you before we merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thekaveman @machikoyasuda I can confirm that this works for me too. I was able to rebuild the base client
image and rebuild the devcontainer.
At first, I got an error about EventScrubber
not being found, but after rebuilding the client
image, that went away. I guess my sentry_sdk
version was off somewhere. Anyways, all good 👍
@angela-tran Just out of curiosity, was the first VS Code container install slower for you? |
Note: This PR closes this bug issue in Eligibility Server: cal-itp/eligibility-server#247 |
Not that I remember 🤔 The first build always takes more time than subsequent ones that use cached layers I think, and it didn't stand out to me as taking longer than normal |
fixes #1357 and cal-itp/eligibility-server#247
see #1353 in favor of this solution for background
Testing
How to test
bin/build.sh
Re-build without Cache and re-open in container
git status
pytest
Re-open in container
(using the cached dev container) and test steps again