Fix: Configurable traces sampling rate for Sentry #1360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
back-end
angela-tran
previously approved these changes
Apr 14, 2023
9 tasks
thekaveman
force-pushed
the
fix/sentry-sampling
branch
from
7f87cf7
to
2ae770f
Compare
angela-tran
approved these changes
Apr 20, 2023
1 task
thekaveman
added a commit
to cal-itp/eligibility-server
that referenced
this pull request
Oct 11, 2023
thekaveman
added a commit
to cal-itp/eligibility-server
that referenced
this pull request
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1359 and this Slack thread, more work to reduce unnecessary traffic we send to Sentry.
This PR introduces an environment-specific configuration for the Sentry
traces_sample_ratesetting using our standard environment variable / key vault pattern.The new default is
0.0, so this has to be turned on explicitly. Before we were hard-coding to1.0(i.e. send 100% of transactions) in all environments.This is temporarily on top of #1358 because that PR also introduced a new Sentry config, though otherwise unrelated.