Refactor: agency links context

[angela-tran]

Closes #1054

This PR implements the proposed solution on the ticket so that for the three pages that show agency links (help, unverified, and retry):

• we remove the {% if "agency" in agency_button.classes %} check
• we remove the {% if "btn-primary" in back_button.classes %} check

Testing locally

/help and /unverified are easy to test by going through the flow (use Courtesy Card with ineligible user credentials).

To test the /enrollment/retry view, you can modify the code as follows. Then, make sure to populate an agency in your session (either through the agency selector modal or going directly to an agency's slug) so that you can go directly to the endpoint and see that agency's contact links.

-@decorator_from_middleware(EligibleSessionRequired)
+# @decorator_from_middleware(EligibleSessionRequired)
    """View handler for a recoverable failure condition."""
-    if request.method == "POST":
+    if request.method == "GET":

[machikoyasuda]

Testing locally - all looks good

• Help page without choosing an agency

• Help page after selecting MST

• Unverified

Testing locally - enrollment/retry

I changed my local code at https://github.com/cal-itp/benefits/blob/145ebc126b48fb78739c61557892c3feb0e1cedc/benefits/enrollment/views.py#LL146C2-L146C2 according to your notes, and then routing to http://localhost:11369/enrollment/retry directly. I get the screenshot above. No agency links. Not sure if this is a bug on my configuration side, or the PR itself

[machikoyasuda]

Great solution 🎊 So much better than my hacky past logic!

[angela-tran]

I get the screenshot above. No agency links. Not sure if this is a bug on my configuration side, or the PR itself

Ah, yeah I forgot to mention a required step. You'll want to have an agency in your session, so that means you should start from the homepage, choose a transit provider, and then go to /enrollment/retry.

[machikoyasuda]

@angela-tran Got it! I went through the flow properly (entered in an eligible Courtesy Card user) and got to the LP screen, then manually went to http://localhost:11369/enrollment/retry and it worked:

[thekaveman]

Agreed this code looks much clearer! Nice work 👍

[angela-tran]

Thanks for the reviews @machikoyasuda and @thekaveman! ☺️