Fix: migrations formatting #1438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
deployment-dev
machikoyasuda
approved these changes
Jun 21, 2023
There was a problem hiding this comment.
LGTM! After I ran the command, the .json files were not updated.
Testing steps
- Run
bin/makemigrations.sh - Ensure that any
.jsonfiles are not updated.
$ bin/makemessages.sh
processing locale es
processing locale en$ git status
On branch fix/migrations-formatting
Your branch is up to date with 'origin/fix/migrations-formatting'.
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git restore <file>..." to discard changes in working directory)
modified: benefits/locale/en/LC_MESSAGES/django.po
modified: benefits/locale/es/LC_MESSAGES/django.po
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1437
Modifies the formatting command so that it only applies to Python files.