Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: AuthProvider supports_sign_out #1462

Merged
merged 6 commits into from Jun 29, 2023
Merged

Refactor: AuthProvider supports_sign_out #1462

merged 6 commits into from Jun 29, 2023

Conversation

angela-tran
Copy link
Member

@angela-tran angela-tran commented Jun 28, 2023 •
edited

Closes #1456

@angela-tran angela-tran added this to the Veterans milestone Jun 28, 2023
@angela-tran angela-tran self-assigned this Jun 28, 2023
@github-actions github-actions bot added back-end Django views, sessions, middleware, models, migrations etc. front-end HTML/CSS/JavaScript and Django templates deployment-dev [auto] Changes that will trigger a deploy if merged to dev migrations [auto] Review for potential model changes/needed data migrations updates and removed front-end HTML/CSS/JavaScript and Django templates back-end Django views, sessions, middleware, models, migrations etc. labels Jun 28, 2023
@thekaveman
Copy link
Member

Just an early thought, feel free to disregard -- maybe instead of an explicit field (causing the test/migration to fail), maybe a calculated field (property) based on the presence or absence of the sign out button text?

@angela-tran
Copy link
Member Author

Just an early thought, feel free to disregard -- maybe instead of an explicit field (causing the test/migration to fail), maybe a calculated field (property) based on the presence or absence of the sign out button text?

Yeah, that will make things simpler 👍

@angela-tran angela-tran marked this pull request as ready for review June 28, 2023 23:52
@angela-tran angela-tran requested a review from a team as a code owner June 28, 2023 23:52
machikoyasuda
machikoyasuda reviewed Jun 28, 2023
View reviewed changes
benefits/core/migrations/0002_data.py
@@ -139,7 +139,7 @@ def load_data(app, *args, **kwargs):

veteran_auth_provider = AuthProvider.objects.create(
sign_in_button_label=_("eligibility.buttons.veteran.signin"),
sign_out_button_label=_("eligibility.buttons.veteran.signout"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this line from django.po too?

machikoyasuda
machikoyasuda previously approved these changes Jun 29, 2023
View reviewed changes
thekaveman
thekaveman previously approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@thekaveman thekaveman left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could use a couple quick Model tests for this property, but I won't block for it.

@thekaveman thekaveman mentioned this pull request Jun 29, 2023
Closed
8 tasks
@angela-tran
Copy link
Member Author

Rebased to resolve merge conflicts

@angela-tran
Copy link
Member Author

angela-tran commented Jun 29, 2023 •
edited

I think we could use a couple quick Model tests for this property, but I won't block for it.

I could leave #1456 open and add tests in a separate PR to then close the ticket. Added tests in 6ed9405

thekaveman
thekaveman approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@angela-tran angela-tran merged commit ced3749 into dev Jun 29, 2023
13 checks passed
@angela-tran angela-tran deleted the refactor/supports-sign-out branch June 29, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thekaveman thekaveman thekaveman approved these changes

@machikoyasuda machikoyasuda machikoyasuda left review comments

Assignees

@angela-tran angela-tran

Labels
deployment-dev [auto] Changes that will trigger a deploy if merged to dev migrations [auto] Review for potential model changes/needed data migrations updates
Projects
None yet
Milestone
Veteran rider enrollment pathway
Development

Successfully merging this pull request may close these issues.

Refactor sign-out link logic for AuthProvider's that support it
3 participants
@angela-tran @thekaveman @machikoyasuda