Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: verifier radio template #1489

Merged
merged 7 commits into from
Jul 7, 2023
Merged

Refactor: verifier radio template #1489

merged 7 commits into from
Jul 7, 2023

Commits on Jul 6, 2023

  1. refactor: extract verifier radio label out to separate include template

    @angela-tran
    angela-tran committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    b365036 View commit details
    Browse the repository at this point in the history

  2. refactor: add blocks to verifier radio label include to allow overrides

    @angela-tran
    angela-tran committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    1c44e41 View commit details
    Browse the repository at this point in the history

  3. refactor: introduce selection_label_template field 

    make other selection-label-related fields optional
    @angela-tran
    angela-tran committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    b2ed467 View commit details
    Browse the repository at this point in the history

  4. refactor: add msgids to verifier-specific radio label templates

    @angela-tran
    angela-tran committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    d0964cf View commit details
    Browse the repository at this point in the history

  5. refactor(form): render radio label using selection_label_template 

    basically, change from using one include to verifier's include
    @angela-tran
    angela-tran committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    1d2fa03 View commit details
    Browse the repository at this point in the history

  6. test: add missing field to EligibilityVerifier fixture

    @angela-tran
    angela-tran committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    bd04882 View commit details
    Browse the repository at this point in the history

  7. refactor(models): remove unused selection label translation fields 

    they've been moved to each verifier's template
    @angela-tran
    angela-tran committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    4ded806 View commit details
    Browse the repository at this point in the history