Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons: Use copy for button capitalization, not CSS #1501

Merged
merged 2 commits into from Jul 7, 2023

Conversation

machikoyasuda
Copy link
Member

@machikoyasuda machikoyasuda commented Jul 7, 2023

closes #1483

There have been app-wide changes to how buttons are capitalized or not. This PR intends to make all those changes in 1 PR (but no wording changes).

What this PR does

  • Removes CSS logic for button text capitalization. The capitalization must be correct in the django.po file. The reason for this is because some buttons are capitalized, but not all. So there is no 1 style that can be applied to all buttons.
  • Updates django.po file with all new capitalization in English and Spanish.

What changed

These are all capitalized

  • Return Home|| Regresar a la Página Principal for 404, 400, 500 pages
  • Get Started (Empezar, stays the same for Es) for Agency Index page
  • Go Back || Regresar a la Página Principal for Help page

These have mixed casing

  • Choose your Provider Elija su Proveedor for Index page
  • Choose this Benefit Elija este Beneficio for Elig Index page
  • Connect your Card for Enrollment page

What didn't need to be updated but now looks different b/c of CSS

  • Check status || Verificación de estatus now has mixed casing (But will have the last word changed from status to eligibility in the copy changes to come

@github-actions github-actions bot added deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates i18n Copy: Language files or Django i18n framework labels Jul 7, 2023
@machikoyasuda machikoyasuda marked this pull request as ready for review July 7, 2023 03:09
@machikoyasuda machikoyasuda requested a review from a team as a code owner July 7, 2023 03:09
@machikoyasuda machikoyasuda self-assigned this Jul 7, 2023
@machikoyasuda machikoyasuda added this to the Veterans milestone Jul 7, 2023
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is simpler than #1498.

We can merge this first and I can rebase on this, instead of the other way around.

This one looks ready to go now without any conflicts.

@thekaveman thekaveman mentioned this pull request Jul 7, 2023
4 tasks
@machikoyasuda machikoyasuda merged commit 5c418d5 into dev Jul 7, 2023
13 checks passed
@machikoyasuda machikoyasuda deleted the feat/button-casing branch July 7, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates i18n Copy: Language files or Django i18n framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Buttons: Lowercase pronoun in all Buttons
2 participants