Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Eligibility index #1517

Merged
merged 6 commits into from Jul 13, 2023
Merged

Refactor: Eligibility index #1517

merged 6 commits into from Jul 13, 2023

Conversation

thekaveman
Copy link
Member

@thekaveman thekaveman commented Jul 11, 2023 •
edited

Closes #1472, refactors eligibility:index using the new pattern from #1442 (comment).

Also updates the devcontainer settings for djLint as prettier seemed to take over at one point and overwrite the formatting.

@thekaveman thekaveman requested a review from a team as a code owner July 11, 2023 17:47
@github-actions github-actions bot added back-end Django views, sessions, middleware, models, migrations etc. deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates migrations [auto] Review for potential model changes/needed data migrations updates i18n Copy: Language files or Django i18n framework and removed back-end Django views, sessions, middleware, models, migrations etc. migrations [auto] Review for potential model changes/needed data migrations updates labels Jul 11, 2023
@thekaveman thekaveman marked this pull request as draft July 11, 2023 17:47
@thekaveman thekaveman marked this pull request as ready for review July 11, 2023 18:19
@thekaveman thekaveman self-assigned this Jul 11, 2023
angela-tran
angela-tran previously approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@angela-tran angela-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me 👍

@thekaveman thekaveman mentioned this pull request Jul 11, 2023
Closed
20 tasks
@thekaveman thekaveman force-pushed the refactor/eligibility-index branch 3 times, most recently from 479ed3e to 421b3f9 Compare July 12, 2023 04:58
@thekaveman thekaveman added this to the Veterans milestone Jul 12, 2023
@angela-tran angela-tran mentioned this pull request Jul 12, 2023
Closed
6 tasks
angela-tran
angela-tran previously approved these changes Jul 12, 2023
View reviewed changes
@thekaveman
Copy link
Member Author

@angela-tran I'll wait for you to merge #1524 since this PR is making more substantial changes to the index page.

@thekaveman thekaveman changed the base branch from dev to feat/login-gov-help-modal July 13, 2023 16:45
Base automatically changed from feat/login-gov-help-modal to dev July 13, 2023 16:46
@thekaveman
Copy link
Member Author

thekaveman commented Jul 13, 2023 •
edited

@angela-tran rebased on your work from #1524

angela-tran
angela-tran previously approved these changes Jul 13, 2023
View reviewed changes
@thekaveman
Copy link
Member Author

Sorry @angela-tran I felt like I shouldn't just delete these test assertions

@angela-tran
Copy link
Member

Sorry @angela-tran I felt like I shouldn't just delete these test assertions

That's fair. Good idea to check that the one in the response matches the one on the model 👍

@thekaveman thekaveman merged commit a5455b0 into dev Jul 13, 2023
13 checks passed
@thekaveman thekaveman deleted the refactor/eligibility-index branch July 13, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angela-tran angela-tran angela-tran approved these changes

@machikoyasuda machikoyasuda Awaiting requested review from machikoyasuda

Assignees

@thekaveman thekaveman

Labels
back-end Django views, sessions, middleware, models, migrations etc. deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates i18n Copy: Language files or Django i18n framework
Projects
None yet
Milestone
Veteran rider enrollment pathway
Development

Successfully merging this pull request may close these issues.

Eligibility Index - Update copy
2 participants
@thekaveman @angela-tran