Refactor: home button #1522
Merged
Refactor: home button #1522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
front-end
thekaveman
force-pushed
the
refactor/eligibility-index
branch
2 times, most recently
from
8f3f977
to
479ed3e
Compare
thekaveman
force-pushed
the
refactor/home-button
branch
from
0e830cd
to
594bff2
Compare
thekaveman
force-pushed
the
refactor/eligibility-index
branch
from
479ed3e
to
421b3f9
Compare
thekaveman
force-pushed
the
refactor/home-button
branch
from
594bff2
to
c621403
Compare
20 tasks
thekaveman
force-pushed
the
refactor/eligibility-index
branch
from
421b3f9
to
1159487
Compare
thekaveman
force-pushed
the
refactor/home-button
branch
from
c621403
to
1802385
Compare
thekaveman
force-pushed
the
refactor/home-button
branch
from
1802385
to
3a8dd77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1520
The
eligibility:unverifiedview uses the home button construct. This also shows up in thecore:helpview as well as in most error pages incore.This PR moves the content to an include, with some added context for the user's current
session.originvia a newcontext_processor.The include is used explicitly where it is needed in templates, removing the need for the
Button.home()viewmodel helper.