Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: template and msgid naming #1533

Merged
merged 7 commits into from Jul 14, 2023
Merged

Fix: template and msgid naming #1533

merged 7 commits into from Jul 14, 2023

Conversation

thekaveman
Copy link
Member

@thekaveman thekaveman commented Jul 13, 2023 •
edited

Big rename. Closes #1518

@github-actions github-actions bot added migrations [auto] Review for potential model changes/needed data migrations updates front-end HTML/CSS/JavaScript and Django templates back-end Django views, sessions, middleware, models, migrations etc. i18n Copy: Language files or Django i18n framework and removed back-end Django views, sessions, middleware, models, migrations etc. labels Jul 13, 2023
@thekaveman thekaveman force-pushed the fix/naming branch 3 times, most recently from 87e6265 to f9ddfec Compare July 13, 2023 23:02
Base automatically changed from feat/eligibility-start-senior-help-modal to dev July 13, 2023 23:08
@thekaveman thekaveman marked this pull request as ready for review July 13, 2023 23:16
@thekaveman thekaveman requested a review from a team as a code owner July 13, 2023 23:16
@thekaveman thekaveman self-assigned this Jul 13, 2023
angela-tran
angela-tran approved these changes Jul 14, 2023
View reviewed changes
Copy link
Member

@angela-tran angela-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

@thekaveman
Copy link
Member Author

Good! I wanted to get this done and merged so we don't have to think about it anymore / keep seeing all the variations.

It's going to break #1523 though so I'll work on a rebase of that after I merge.

@thekaveman thekaveman merged commit 5efdcb8 into dev Jul 14, 2023
13 checks passed
@thekaveman thekaveman deleted the fix/naming branch July 14, 2023 16:30
@thekaveman thekaveman mentioned this pull request Jul 14, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angela-tran angela-tran angela-tran approved these changes

Assignees

@thekaveman thekaveman

Labels
front-end HTML/CSS/JavaScript and Django templates i18n Copy: Language files or Django i18n framework migrations [auto] Review for potential model changes/needed data migrations updates
Projects
None yet
Milestone
UI composition improvements [eng]
Development

Successfully merging this pull request may close these issues.

Adjust naming per recent conversation
2 participants
@thekaveman @angela-tran