Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: error pages #1536

Merged
merged 11 commits into from Jul 18, 2023
Merged

Refactor: error pages #1536

merged 11 commits into from Jul 18, 2023

Conversation

thekaveman
Copy link
Member

For #1442

@github-actions github-actions bot added back-end Django views, sessions, middleware, models, migrations etc. i18n Copy: Language files or Django i18n framework front-end HTML/CSS/JavaScript and Django templates tests Related to automated testing (unit, UI, integration, etc.) and removed i18n Copy: Language files or Django i18n framework labels Jul 17, 2023
@thekaveman thekaveman mentioned this pull request Jul 17, 2023
Closed
20 tasks
@thekaveman thekaveman self-assigned this Jul 17, 2023
Base automatically changed from refactor/eligibility-unverified to dev July 17, 2023 16:58
@thekaveman thekaveman marked this pull request as ready for review July 18, 2023 16:13
@thekaveman thekaveman requested a review from a team as a code owner July 18, 2023 16:13
angela-tran
angela-tran reviewed Jul 18, 2023
View reviewed changes
benefits/core/views.py Show resolved Hide resolved
benefits/core/middleware.py Show resolved Hide resolved
@thekaveman thekaveman marked this pull request as draft July 18, 2023 21:13
@thekaveman thekaveman marked this pull request as ready for review July 18, 2023 22:10
@thekaveman thekaveman merged commit e60a4c9 into dev Jul 18, 2023
13 checks passed
@thekaveman thekaveman deleted the refactor/error-pages branch July 18, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angela-tran angela-tran angela-tran approved these changes

Assignees

@thekaveman thekaveman

Labels
back-end Django views, sessions, middleware, models, migrations etc. front-end HTML/CSS/JavaScript and Django templates tests Related to automated testing (unit, UI, integration, etc.)
Projects
Digital Services
Status: Done
Milestone
UI composition improvements [eng]
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thekaveman @angela-tran