Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: remove Transit Agency viewmodel #1541

Merged
merged 2 commits into from Jul 19, 2023
Merged

Refactor: remove Transit Agency viewmodel #1541

merged 2 commits into from Jul 19, 2023

Conversation

thekaveman
Copy link
Member

For #1442

@github-actions github-actions bot added back-end Django views, sessions, middleware, models, migrations etc. front-end HTML/CSS/JavaScript and Django templates labels Jul 18, 2023
@thekaveman thekaveman mentioned this pull request Jul 17, 2023
Closed
20 tasks
@thekaveman
refactor(agency-selector): use context.active_agencies
1286234
@thekaveman
refactor(viewmodels): remove unused TransitAgency
79e3c23 
mostly ported to a context_processor so
agency data is available with all requests
@thekaveman thekaveman force-pushed the refactor/viewmodels-transit-agency branch from a5accdc to 79e3c23 Compare July 18, 2023 04:53
@thekaveman thekaveman self-assigned this Jul 18, 2023
Base automatically changed from refactor/error-pages to dev July 18, 2023 22:23
@thekaveman thekaveman marked this pull request as ready for review July 18, 2023 22:23
@thekaveman thekaveman requested a review from a team as a code owner July 18, 2023 22:23
angela-tran
angela-tran approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@angela-tran angela-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice cleanup

@thekaveman thekaveman merged commit 8ee688c into dev Jul 19, 2023
10 checks passed
@thekaveman thekaveman deleted the refactor/viewmodels-transit-agency branch July 19, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angela-tran angela-tran angela-tran approved these changes

Assignees

@thekaveman thekaveman

Labels
back-end Django views, sessions, middleware, models, migrations etc. front-end HTML/CSS/JavaScript and Django templates
Projects
Digital Services
Status: Done
Milestone
UI composition improvements [eng]
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thekaveman @angela-tran