Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: remove icon/media item view models #1542

Merged
merged 5 commits into from Jul 21, 2023
Merged

Refactor: remove icon/media item view models #1542

merged 5 commits into from Jul 21, 2023

Conversation

thekaveman
Copy link
Member

For #1442

@github-actions github-actions bot added back-end Django views, sessions, middleware, models, migrations etc. front-end HTML/CSS/JavaScript and Django templates labels Jul 18, 2023
@thekaveman thekaveman mentioned this pull request Jul 18, 2023
Closed
20 tasks
@thekaveman thekaveman changed the title Refactor: Icon view model Refactor: Remove icon/media item view models Jul 18, 2023
@thekaveman thekaveman changed the title Refactor: Remove icon/media item view models Refactor: remove icon/media item view models Jul 18, 2023
@thekaveman thekaveman self-assigned this Jul 18, 2023
Base automatically changed from refactor/viewmodels-transit-agency to dev July 19, 2023 15:56
@thekaveman thekaveman marked this pull request as ready for review July 19, 2023 17:13
@thekaveman thekaveman requested a review from a team as a code owner July 19, 2023 17:13
@thekaveman thekaveman marked this pull request as draft July 19, 2023 17:15
@thekaveman thekaveman marked this pull request as ready for review July 21, 2023 16:42
angela-tran
angela-tran approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@angela-tran angela-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I tested out the app locally and didn't notice any regressions.

@thekaveman thekaveman merged commit 01b2b6d into dev Jul 21, 2023
13 checks passed
@thekaveman thekaveman deleted the refactor/icons branch July 21, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angela-tran angela-tran angela-tran approved these changes

Assignees

@thekaveman thekaveman

Labels
back-end Django views, sessions, middleware, models, migrations etc. front-end HTML/CSS/JavaScript and Django templates
Projects
Digital Services
Status: Done
Milestone
UI composition improvements [eng]
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thekaveman @angela-tran