New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes: CSS column alignment #1550
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good.
Just wondering about:
I recommend not codifying the col-lg-8 width into the base.html itself.
Would that come in a later refactor?
No - because not all pages have |
@machikoyasuda that was my question, it's still in this PR -- will removing it be in a separate PR? (I guess so) |
@thekaveman Oh sorry I think I figured out your question. I DO recommend |
closes #1548
col-lg-8
, notcol-lg-10
. Index page, Agency Index page and Enrollment Success is an outlier and is not part of this. No changes necessary for 404/400/500 pages. Also one page has acol-lg-6
H1 wrapper container instead. Because some pages are actually different from others, I recommend not codifying thecol-lg-8
width into thebase.html
itself.Screenshots