Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: CSS column alignment #1550

Merged
merged 6 commits into from Jul 21, 2023
Merged

Fixes: CSS column alignment #1550

merged 6 commits into from Jul 21, 2023

Conversation

machikoyasuda
Copy link
Member

@machikoyasuda machikoyasuda commented Jul 21, 2023

closes #1548

  • Desktop: Container width for most* pages is now col-lg-8, not col-lg-10. Index page, Agency Index page and Enrollment Success is an outlier and is not part of this. No changes necessary for 404/400/500 pages. Also one page has a col-lg-6 H1 wrapper container instead. Because some pages are actually different from others, I recommend not codifying the col-lg-8 width into the base.html itself.
  • Desktop: Media Item grid gap is now lower to 24px.
  • Mobile: Should have no changes

Screenshots

image image image image image image

@github-actions github-actions bot added deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates back-end Django views, sessions, middleware, models, migrations etc. labels Jul 21, 2023
@machikoyasuda machikoyasuda marked this pull request as ready for review July 21, 2023 02:14
@machikoyasuda machikoyasuda requested a review from a team as a code owner July 21, 2023 02:14
@machikoyasuda machikoyasuda self-assigned this Jul 21, 2023
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

Just wondering about:

I recommend not codifying the col-lg-8 width into the base.html itself.

Would that come in a later refactor?

@machikoyasuda
Copy link
Member Author

machikoyasuda commented Jul 21, 2023

@thekaveman

_Just wondering about:

I recommend not codifying the col-lg-8 width into the base.html itself.

Would that come in a later refactor?_

No - because not all pages have col-lg-8 width by default. So I'd rather not put it in.. because it's not on all pages. Help, Enrollment Success, Log Out, Agency Index, Index all are different. If "base" is truly to be "base", it should serve all pages.

@machikoyasuda machikoyasuda merged commit 3d3c65d into dev Jul 21, 2023
11 checks passed
@machikoyasuda machikoyasuda deleted the fix/1548-fix-veterans-grid branch July 21, 2023 16:53
@thekaveman
Copy link
Member

@thekaveman

_Just wondering about:

I recommend not codifying the col-lg-8 width into the base.html itself.

Would that come in a later refactor?_

No - because not all pages have col-lg-8 width by default. So I'd rather not put it in.. because it's not on all pages. Help, Enrollment Success, Log Out, Agency Index, Index all are different. If "base" is truly to be "base", it should serve all pages.

@machikoyasuda that was my question, it's still in this PR -- will removing it be in a separate PR? (I guess so)

@machikoyasuda
Copy link
Member Author

@thekaveman Oh sorry I think I figured out your question.

https://github.com/cal-itp/benefits/pull/1550/files#diff-e2ae5f60bb472effafac24b079fcbb1ffd09dcc5d8df2d22cab07417d222f925R72-R87

I DO recommend col-lg-8 be in headline and explanatory-text -- b/c all pages do use this, as this PR reflects. But I do not recommend col-lg-8 to be coded into base.html for the inner-content portion, cos that's where it differs for the other pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back-end Django views, sessions, middleware, models, migrations etc. deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Grid-width issue
2 participants