Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Help copy - Littlepay #1561

Merged
merged 4 commits into from
Jul 28, 2023
Merged

Chore: Help copy - Littlepay #1561

merged 4 commits into from
Jul 28, 2023

Conversation

angela-tran
Copy link
Member

@angela-tran angela-tran commented Jul 21, 2023

Part of #1544

This PR updates the section explaining what Littlepay is. Reuses msgids from modal.

@angela-tran angela-tran added this to the Veterans milestone Jul 21, 2023
@angela-tran angela-tran self-assigned this Jul 21, 2023
@github-actions github-actions bot added deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates i18n Copy: Language files or Django i18n framework labels Jul 21, 2023
@angela-tran angela-tran marked this pull request as ready for review July 26, 2023 22:13
@angela-tran angela-tran requested a review from a team as a code owner July 26, 2023 22:13
@angela-tran angela-tran marked this pull request as draft July 26, 2023 22:23
@angela-tran angela-tran marked this pull request as ready for review July 26, 2023 22:27
@machikoyasuda
Copy link
Member

image image

@angela-tran @srhhnry Is there a decided official style on whether the . comes before or after the external link arrow? I personally prefer the . comes after the external link arrow (even though the code is a little more annoying for that).

And should that same style apply to the modal question mark icon?

image

@srhhnry
Copy link
Member

srhhnry commented Jul 27, 2023

Yup, punctuation after the icon per the Styleguide (info on the desktop template under the Text Layout section).

It's been sort of difficult to portray that in Figma because the Google Sheets Sync doesn't interact with components (like the modal button, for instance), so I've added punctuation in manually where I see it, but any space adjustment or resync of the sheet can create spacing issues (:-/).

@srhhnry
Copy link
Member

srhhnry commented Jul 27, 2023

Also, just a heads up, punctuation after icon is based on USWDS: https://designsystem.digital.gov/components/link/

@angela-tran
Copy link
Member Author

Sounds good @srhhnry , and thank you @machikoyasuda for asking for this to be clarified! I was going off the punctuation shown in the individual screens, but now I know to reference the Style Guide. I will fix

@angela-tran
Copy link
Member Author

Dropped the commit that was solely for moving the period inside the link. Will open a separate PR to fix the other external link punctuation in the app

@angela-tran angela-tran merged commit 4d25738 into dev Jul 28, 2023
8 checks passed
@angela-tran angela-tran deleted the chore/help-copy-littlepay branch July 28, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates i18n Copy: Language files or Django i18n framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants