Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: ignore line that causes prettier bug #1568

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Conversation

machikoyasuda
Copy link
Member

Currently, there's a version mismatch between the prettier in VSCode and the one in pre-commit. The latest version of prettier has a new rule, that gets tripped up on 1 line of CSS. This PR ignores that line until the 2 versions match.

@machikoyasuda machikoyasuda requested a review from a team as a code owner July 27, 2023 03:34
@github-actions github-actions bot added front-end HTML/CSS/JavaScript and Django templates deployment-dev [auto] Changes that will trigger a deploy if merged to dev and removed front-end HTML/CSS/JavaScript and Django templates labels Jul 27, 2023
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find and fix! 💪

@machikoyasuda machikoyasuda merged commit 199c0e9 into dev Jul 27, 2023
11 checks passed
@machikoyasuda machikoyasuda deleted the chore/ignore-line branch July 27, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment-dev [auto] Changes that will trigger a deploy if merged to dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants