Fix: Skip Nav - Remove skip nav page jank #1663
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1661
This was bothering me a lot 馃槗 and I finally looked up a solid, easy solution w/o any drawbacks. Currently, when using the Skip Nav to get to
#main-content
and then continuing to use the keyboard for navigation, the site will scroll you back up the page when you go from#main-content
toPrevious Page
. It creates a jarring user experience, where the page goes down, and then back up. This PR fixes it by adding ascroll-padding-top
that's greater than the height of the nav (80px), so the screen doesn't move back up. This solution also doesn't affect anything else (like the footer position, main container height, etc).scroll-padding-top
from this: https://css-tricks.com/fixed-headers-on-page-links-and-overlapping-content-oh-my/