Fix: Update Spanish tense for Login.gov modal #1712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machikoyasuda
changed the title
github-actions
bot
added
deployment-dev
thekaveman
requested changes
Sep 8, 2023
There was a problem hiding this comment.
At least one more snuck in at the bottom: https://github.com/cal-itp/benefits/pull/1712/files#diff-748b0299f076e6e9a7c2a8bd1ecae94e02768b9c07bd8a84ddfa4ebdb62752fdR576
machikoyasuda
force-pushed
the
feat/1709-login-gov-spanish
branch
from
7dcdab1
to
e85122f
Compare
|
@thekaveman Thanks for that catch! I searched thru the Spanish file to make sure there aren't any more |
|
Hey folks- I'm giving a talk about modern software delivery to some public policy students today and this was a great example for me to show. Thanks again for working in the open! 🌤️ 🙌 |
|
Nice to see you @afeld! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1709
The rest of the Spanish copy on the app uses the formal usted tense (for pronouns, verbs). This PR updates the Login.gov modal from informal tu tense to formal usted tense.
Note: This would be important to note in the #1653 as instructions for Spanish translation teams.