Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Veterans: add Sign Out link for Veterans/Login.gov flow #1713

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Veterans: add Sign Out link for Veterans/Login.gov flow #1713

merged 1 commit into from
Sep 11, 2023

Conversation

machikoyasuda
Copy link
Member

@machikoyasuda machikoyasuda commented Sep 7, 2023 •
edited

closes #1707

What this PR does

  • Rename the button--sign-out--senior and link--sign-out--senior files to use --login-gov suffix
  • Add sign_out_button_template, sign_out_link_template to Veteran's

How to test this PR

For the Veterans flow and the Senior flow:

  • Display Sign out of Login button on Enrollment view
  • Display Sign out of Login button on Eligibility Error view This one is hard to test)
  • Display Sign out of Login button on Payment Error view (This one is hard to test)
  • Display Sign out of Login button on Enrollment Success view

How I tested this locally

  • Since the Login.gov/VA IDG flow is not yet available, I faked it by setting my VA Auth Provider to have the same exact configuration as the Senior one, and went thru the flow to at least confirm that the sign out link and buttons are showing up:
image image

@machikoyasuda machikoyasuda self-assigned this Sep 7, 2023
@github-actions github-actions bot added deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates migrations [auto] Review for potential model changes/needed data migrations updates back-end Django views, sessions, middleware, models, migrations etc. and removed deployment-dev [auto] Changes that will trigger a deploy if merged to dev labels Sep 7, 2023
@machikoyasuda machikoyasuda changed the title feat(veterans): add Sign Out link for Veterans/Login.gov flow Veterans: add Sign Out link for Veterans/Login.gov flow Sep 7, 2023
@machikoyasuda machikoyasuda marked this pull request as ready for review September 7, 2023 22:24
@machikoyasuda machikoyasuda requested a review from a team as a code owner September 7, 2023 22:24
@machikoyasuda
Copy link
Member Author

Ready for review @thekaveman @angela-tran

@thekaveman
Copy link
Member

@machikoyasuda @angela-tran

Since the Login.gov/VA IDG flow is not yet available

It is now available and should work from localhost:11369 and dev-benefits, see this long thread in Slack for configuration details: https://cal-itp.slack.com/archives/C037Y3UE71P/p1694210616556309

I updated the Benefits Test Data doc with info about how to create a sandbox Login.gov user that verifies as a Veteran.

@thekaveman
Copy link
Member

@machikoyasuda want to rebase this on the changes from those other PRs?

@machikoyasuda
Copy link
Member Author

Tested locally: Veterans log out
image
image

thekaveman
thekaveman approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I see the link and was able to sign out from:

✅ Eligibility Fail
✅ Enrollment Start
✅ Enrollment Success

@machikoyasuda machikoyasuda merged commit 497c268 into dev Sep 11, 2023
13 checks passed
@machikoyasuda machikoyasuda deleted the feat/1707-veterans-sign-out branch September 11, 2023 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thekaveman thekaveman thekaveman approved these changes

Assignees

@machikoyasuda machikoyasuda

Labels
back-end Django views, sessions, middleware, models, migrations etc. front-end HTML/CSS/JavaScript and Django templates migrations [auto] Review for potential model changes/needed data migrations updates
Projects
None yet
Milestone
Veteran rider enrollment pathway
Development

Successfully merging this pull request may close these issues.

Veteran enrollment pathway: display Login.gov sign-out button views following identity verification
2 participants
@machikoyasuda @thekaveman