Docs: adding veterans use case #1748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
angela-tran
reviewed
Sep 22, 2023
angela-tran
reviewed
Sep 22, 2023
Co-authored-by: Angela Tran <angela@compiler.la>
thekaveman
requested changes
Sep 25, 2023
This styling came with the .md file export from ClickUp. We definitely need to be aware that the Markdown in these exports isn't clean and should be reviewed carefully.
angela-tran
previously approved these changes
Sep 25, 2023
|
@machikoyasuda I think you can merge this once you've had a chance to review. I'm guessing @indexing does not see the 
|
machikoyasuda
approved these changes
Sep 26, 2023
machikoyasuda
suggested changes
Sep 26, 2023
There was a problem hiding this comment.
2 small suggestions @indexing (which you can just click Commit suggestion on) and then we're good!
|
From an earlier comment
@indexing Just curious, whenever the pull request is approved, do you see a "Merge pull request" button? |
Co-authored-by: machiko <machiko@compiler.la>
Co-authored-by: machiko <machiko@compiler.la>
thekaveman
requested changes
Sep 26, 2023
Co-authored-by: Kegan Maher <kegan@compiler.la>
thekaveman
approved these changes
Sep 26, 2023
angela-tran
approved these changes
Sep 26, 2023
|
@machikoyasuda go ahead and merge when you approve -- I confirmed with @indexing he does not currently have the permissions. |
machikoyasuda
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1587