Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: create and mount Azure file share #1775

Merged
merged 2 commits into from Nov 8, 2023
Merged

Feat: create and mount Azure file share #1775

merged 2 commits into from Nov 8, 2023

Conversation

thekaveman
Copy link
Member

@thekaveman thekaveman commented Nov 2, 2023 •
edited

In the spirit of trying something; part of #1773

@thekaveman thekaveman requested a review from a team as a code owner November 2, 2023 23:39
@thekaveman thekaveman self-assigned this Nov 2, 2023
@github-actions github-actions bot added the infrastructure Terraform, Azure, etc. label Nov 2, 2023
@thekaveman thekaveman added this to the Admin tool: v1 milestone Nov 2, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2023

Coverage report

The coverage rate went from 90.91% to 90.91% ⬇️
The branch rate is 85%.

None of the new lines are part of the tested code. Therefore, there is no coverage data about them.

@machikoyasuda machikoyasuda self-requested a review November 6, 2023 23:28
machikoyasuda
machikoyasuda approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@machikoyasuda machikoyasuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@thekaveman thekaveman merged commit c99b74d into dev Nov 8, 2023
10 checks passed
@thekaveman thekaveman deleted the feat/file-share branch November 8, 2023 19:49
@thekaveman thekaveman mentioned this pull request Dec 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machikoyasuda machikoyasuda machikoyasuda approved these changes

@angela-tran angela-tran angela-tran approved these changes

Assignees

@thekaveman thekaveman

Labels
infrastructure Terraform, Azure, etc.
Projects
None yet
Milestone
Admin tool: foundation
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thekaveman @machikoyasuda @angela-tran