Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: back of card, not both front and back #1793

Merged
merged 3 commits into from Nov 17, 2023
Merged

Fix: back of card, not both front and back #1793

merged 3 commits into from Nov 17, 2023

Conversation

machikoyasuda
Copy link
Member

@machikoyasuda machikoyasuda commented Nov 16, 2023 •
edited

closes #1792

image image

@github-actions GitHub Actions
Copy link

Coverage report

The coverage rate went from 90.87% to 90.87% ➡️
The branch rate is 85%.

None of the new lines are part of the tested code. Therefore, there is no coverage data about them.

Diff Coverage details (click to unfold)

benefits/eligibility/forms.py

100% of new lines are covered (80% of the complete file).

@github-actions github-actions bot added i18n Copy: Language files or Django i18n framework deployment-dev [auto] Changes that will trigger a deploy if merged to dev back-end Django views, sessions, middleware, models, migrations etc. labels Nov 16, 2023
@machikoyasuda machikoyasuda marked this pull request as ready for review November 16, 2023 23:53
@machikoyasuda machikoyasuda requested a review from a team as a code owner November 16, 2023 23:53
@machikoyasuda machikoyasuda self-assigned this Nov 16, 2023
@machikoyasuda machikoyasuda added this to the SBMTD Mobility Pass milestone Nov 16, 2023
angela-tran
angela-tran approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@angela-tran angela-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me

@machikoyasuda machikoyasuda merged commit 81f62b4 into dev Nov 17, 2023
13 checks passed
@machikoyasuda machikoyasuda deleted the fix/1792-sbmtd-copy branch November 17, 2023 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angela-tran angela-tran angela-tran approved these changes

Assignees

@machikoyasuda machikoyasuda

Labels
back-end Django views, sessions, middleware, models, migrations etc. deployment-dev [auto] Changes that will trigger a deploy if merged to dev i18n Copy: Language files or Django i18n framework
Projects
None yet
Milestone
SBMTD Mobility Pass
Development

Successfully merging this pull request may close these issues.

SBMTD Mobility Pass Enrollment: Small adjustments to application copy
2 participants
@machikoyasuda @angela-tran