New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Analytics #1818
Docs: Analytics #1818
Conversation
Coverage reportThe coverage rate went from None of the new lines are part of the tested code. Therefore, there is no coverage data about them. |
Ready for review @indexing @angela-tran |
@machikoyasuda Everywhere we mention the "Cal-ITP Benefits application" in the Analytics doc, I proposed we make the text link to https://benefits.calitp.org so readers can easily correlate the documentation to the product. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me @machikoyasuda !
@indexing @machikoyasuda Let's have another think about this, I disagree that we need to link to the app all over our docs pages. By and large we don't expect the audience of the docs to overlap much with the real audience of the app, and we don't need/want to inflate any analytics with drive-bys. We certainly want to link to the app from e.g. the docs homepage. I just don't think we need to make every instance of the phrase link to it. |
closes #953
What this PR does