Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update README.md #1821

Merged
merged 1 commit into from Dec 13, 2023
Merged

docs: Update README.md #1821

merged 1 commit into from Dec 13, 2023

Conversation

indexing
Copy link
Member

  • Added a product mockup (image)
  • Added a hyperlink to the Benefits app in prod
  • Slight adjustments to terms and language in the description

I'm not sure if an image is appropriate for a README file. I was planning to propose we add an image in the documentation, but thought I'd get input on having one here.

- Added a product mockup (image)
- Added a hyperlink to the Benefits app in prod
- Slight adjustments to terms and language in the description

I'm not sure if an image is appropriate for a README file. I was planning to propose we add an image in the documentation, but thought I'd get input on having one here.
@indexing indexing requested a review from a team as a code owner December 13, 2023 00:34
Copy link

Coverage report

The coverage rate went from 90.87% to 90.87% ➡️
The branch rate is 85%.

None of the new lines are part of the tested code. Therefore, there is no coverage data about them.

Copy link
Member

@machikoyasuda machikoyasuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshots in READMEs are totally normal 👍

Copy link
Member

@angela-tran angela-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These updates look good to me

@machikoyasuda machikoyasuda merged commit aa2002d into dev Dec 13, 2023
9 checks passed
@machikoyasuda machikoyasuda deleted the indexing-patch-1 branch December 13, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants