Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: model secret fields #1874

Merged
merged 9 commits into from
Feb 12, 2024
Merged

Refactor: model secret fields #1874

merged 9 commits into from
Feb 12, 2024

Commits on Feb 8, 2024

  1. feat(secrets): Django validator for secret names 

    Azure KeyVault currently enforces the following rules:

    * The value must be between 1 and 127 characters long.
    * Secret names can only contain alphanumeric characters and dashes.

Read more about Azure KeyVault naming rules:
https://learn.microsoft.com/en-us/azure/azure-resource-manager/management/resource-name-rules#microsoftkeyvault

Read more about Django validators:
https://docs.djangoproject.com/en/5.0/ref/validators/#module-django.core.validators
    @thekaveman
    thekaveman committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    c4f7b62 View commit details
    Browse the repository at this point in the history

  2. feat(secrets): Django field for storing secret names

    @thekaveman
    thekaveman committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    5c94f12 View commit details
    Browse the repository at this point in the history

  3. refactor(models): AuthProvider.client_id is a secret field 

    * update definition to use new field
* update migrations
* remove env var from terraform definitions
* move default value to .env.sample
    @thekaveman
    thekaveman committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    ca91759 View commit details
    Browse the repository at this point in the history

  4. refactor(models): EligibilityVerifier.api_auth_key is a secret field 

    * update definition to use new field
* update migrations
* remove env vars from terraform definitions
* move default value to .env.sample
    @thekaveman
    thekaveman committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    cb315e6 View commit details
    Browse the repository at this point in the history

  5. refactor(models): PemData.data could come from a secret field 

    PemData favors the secret, but fallback to a remote URL
this is to allow for simpler turn-key local development

* update definition to use new field
* update migrations
* remove env vars from terraform definitions
* move default keys to .env.sample
    @thekaveman
    thekaveman committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    a4b3675 View commit details
    Browse the repository at this point in the history

  6. refactor(secrets): enforce name validation in helper function

    @thekaveman
    thekaveman committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    bce9ab3 View commit details
    Browse the repository at this point in the history

  7. fix(secrets): env vars can't contain hyphens

    @thekaveman
    thekaveman committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    4ae08a9 View commit details
    Browse the repository at this point in the history

  8. fix(ci): start from the .env.sample

    @thekaveman
    thekaveman committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    0caa851 View commit details
    Browse the repository at this point in the history

  9. refactor(models): rename secret field for clarity

    @thekaveman
    thekaveman committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    3721d8c View commit details
    Browse the repository at this point in the history