Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: use cal-itp/littlepay to check API access #1889

Merged
merged 1 commit into from Feb 14, 2024

Conversation

angela-tran
Copy link
Member

@angela-tran angela-tran commented Feb 13, 2024

Closes #1814

This PR refactors the check-api workflow to use cal-itp/littlepay instead.

Like the previous implementation, this approach checks if it can get an access token for the QA and prod environments. Additionally it does those checks for each participant, as defined in the job matrix.

Before merging

  • Copy contents of config.yaml for this API from LastPass, and add as a repository secret named API_CHECK_CONFIG

Cleanup to do

  • Delete the old secrets used in the previous implementation
  • Re-enable the check-api workflow

@angela-tran angela-tran self-assigned this Feb 13, 2024
@angela-tran angela-tran requested a review from a team as a code owner February 13, 2024 21:54
@github-actions github-actions bot added the actions Related to GitHub Actions workflows label Feb 13, 2024
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

also remove workflow input to simplify since we don't use it
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this is really clever to check out the Littlepay library inside the workflow and install from there!

Seeing that, I wonder if it might make more sense to have this check run in that repo instead?

I really like the new matrix configuration too 👍

@angela-tran
Copy link
Member Author

Seeing that, I wonder if it might make more sense to have this check run in that repo instead?

I could see arguments for either repo. The workflow does send a Slack notification to the Benefits channel if there's a failure, so that might be a reason to keep it here. On the other hand, cal-itp/littlepay pretty much exists to be used in Benefits, so you could say that it's just as valid for it to send notifications to the Benefits channel.

I'll go ahead and merge it in to this repo. Let me know if you feel strongly about moving it.

@angela-tran angela-tran merged commit 493a7ec into dev Feb 14, 2024
8 checks passed
@angela-tran angela-tran deleted the refactor/api-check branch February 14, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions Related to GitHub Actions workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Payment Processor API check workflow to use Back Office API
2 participants