Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: check for existing preview comment before adding one #1910

Merged
merged 1 commit into from Feb 26, 2024

Conversation

thekaveman
Copy link
Member

Closes #1896

@thekaveman thekaveman requested a review from a team as a code owner February 23, 2024 23:53
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

@github-actions github-actions bot added the actions Related to GitHub Actions workflows label Feb 23, 2024
Copy link

@github-actions github-actions bot added the documentation [auto] Improvements or additions to documentation label Feb 23, 2024
Copy link

we don't need a new comment every time a commit is made,
only the first time
@thekaveman
Copy link
Member Author

The second comment here was due to an error in the workflow file, I fixed it and force pushed, and we didn't get a 3rd! So it seems like it's working.

Copy link
Member

@machikoyasuda machikoyasuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is a handy github action!

@thekaveman thekaveman merged commit 0c6e46b into dev Feb 26, 2024
10 checks passed
@thekaveman thekaveman deleted the fix/mkdocs-preview-comment branch February 26, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions Related to GitHub Actions workflows documentation [auto] Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix docs preview comment workflow to only comment once
2 participants