Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add YouTube videos for enrollment pathways #1924

Merged
merged 2 commits into from Mar 5, 2024

Conversation

@machikoyasuda machikoyasuda requested a review from a team as a code owner March 1, 2024 02:41
Copy link

github-actions bot commented Mar 1, 2024

Coverage report

This PR does not seem to contain any modification to coverable code.

@machikoyasuda machikoyasuda self-assigned this Mar 1, 2024
@github-actions github-actions bot added the documentation [auto] Improvements or additions to documentation label Mar 1, 2024
Copy link

github-actions bot commented Mar 1, 2024

Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. One question, do we still need the GIF file in the repo?

https://github.com/cal-itp/benefits/blob/dev/docs/enrollment-pathways/img/senior-success.gif

indexing
indexing previously approved these changes Mar 4, 2024
Copy link
Member

@indexing indexing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The video embeds work for me. Thanks!

@machikoyasuda
Copy link
Member Author

https://github.com/cal-itp/benefits/blob/dev/docs/enrollment-pathways/img/senior-success.gif

As long as no one is using this link anywhere..! MST isn't, so we should be good.

Copy link
Member

@indexing indexing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate a little house-keeping.

@machikoyasuda
Copy link
Member Author

This is set to automerge as soon as @thekaveman or @angela-tran approves. Thank you!

@machikoyasuda machikoyasuda merged commit 6aa03f2 into dev Mar 5, 2024
10 checks passed
@machikoyasuda machikoyasuda deleted the docs/add-video-walkthrus branch March 5, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation [auto] Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants