Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: CalFresh re-enrollment error #1992

Merged
merged 4 commits into from
May 2, 2024
Merged

Conversation

thekaveman
Copy link
Member

@thekaveman thekaveman commented Mar 28, 2024

Closes #1921.

Currently on top of #1968 since both of these PRs introduce migrations.

Currently on top of #1989 since both of these PRs work on the enrollment views.

Currently on top of #2053 since both of these PRs introduce migrations.

How to test

  1. (Temporarily) override the value returned by session.enrollment_expiry() e.g.

    expiry = datetime(2024, 5, 31, tzinfo=timezone.utc).timestamp()
    if expiry:
        return datetime.fromtimestamp(expiry, tz=timezone.utc)
    else:
        return None
  2. In the Admin, update a flow that you can pass eligibility for (e.g. MST Courtesy Cards): check supports expiration and add a value for the expiration days, re-enrollment days, and re-enrollment error template = enrollment/reenrollment-error--calfresh.html

  3. Pass eligibility

  4. Enter the path /enrollment/reenrollment-error

  5. See the new re-enrollment error page

@thekaveman thekaveman self-assigned this Mar 28, 2024
@github-actions github-actions bot added tests Related to automated testing (unit, UI, integration, etc.) migrations [auto] Review for potential model changes/needed data migrations updates front-end HTML/CSS/JavaScript and Django templates back-end Django views, sessions, middleware, models, migrations etc. i18n Copy: Language files or Django i18n framework and removed tests Related to automated testing (unit, UI, integration, etc.) migrations [auto] Review for potential model changes/needed data migrations updates front-end HTML/CSS/JavaScript and Django templates back-end Django views, sessions, middleware, models, migrations etc. labels Mar 28, 2024
Copy link

github-actions bot commented Mar 28, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  benefits/core
  models.py
  benefits/enrollment
  views.py 134
Project Total  

This report was generated by python-coverage-comment-action

@thekaveman thekaveman force-pushed the feat/calfresh-enrollment-index branch from d854a3e to 1216af6 Compare March 29, 2024 22:18
Base automatically changed from feat/calfresh-enrollment-index to dev April 1, 2024 22:58
@thekaveman thekaveman force-pushed the feat/calfresh-reenrollment-error branch from e3f3a48 to 1cf92fb Compare April 2, 2024 17:30
@thekaveman thekaveman changed the base branch from dev to feat/expiry-date April 2, 2024 17:30
Base automatically changed from feat/expiry-date to dev April 2, 2024 17:30
@thekaveman thekaveman force-pushed the feat/calfresh-reenrollment-error branch from 1cf92fb to e145e20 Compare April 25, 2024 20:20
@thekaveman thekaveman changed the base branch from dev to revert/feat/expiry-date April 25, 2024 20:20
@thekaveman
Copy link
Member Author

Rebased on #2052

Base automatically changed from revert/feat/expiry-date to dev April 25, 2024 21:32
@thekaveman thekaveman force-pushed the feat/calfresh-reenrollment-error branch from e145e20 to ca17765 Compare May 1, 2024 19:31
@thekaveman thekaveman changed the base branch from dev to refactor/agency-card-eligibility-error May 1, 2024 19:32
@thekaveman
Copy link
Member Author

Rebased on #2053

@thekaveman thekaveman marked this pull request as ready for review May 1, 2024 19:38
@thekaveman thekaveman requested a review from a team as a code owner May 1, 2024 19:38
@thekaveman
Copy link
Member Author

I figure this can be reviewed and merged after #2053, similar to how we did for #1988.

This page won't be available until we explicitly turn it on for a flow, after completing #2062 where we can really test that it works with live data. Until then, it won't impact any production users.

Base automatically changed from refactor/agency-card-eligibility-error to dev May 1, 2024 19:52
@thekaveman thekaveman force-pushed the feat/calfresh-reenrollment-error branch from ca17765 to c9d4716 Compare May 1, 2024 20:14
@thekaveman thekaveman merged commit 7c45fec into dev May 2, 2024
13 checks passed
@thekaveman thekaveman deleted the feat/calfresh-reenrollment-error branch May 2, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Copy: Language files or Django i18n framework migrations [auto] Review for potential model changes/needed data migrations updates tests Related to automated testing (unit, UI, integration, etc.)
Projects
None yet
2 participants